update fv3 files with fms.2021.03#380
Closed
junwang-noaa wants to merge 2 commits into
Closed
Conversation
Collaborator
|
This PR was merged as part of #379 |
bbakernoaa
pushed a commit
to bbakernoaa/fv3atm
that referenced
this pull request
Oct 20, 2025
* Changes to idealized test case to allow for more options * Minor text fix * Addition of forpy_mod file and make commands. * Inclusion of forpy_mod code and make * Include forpy module in nh_core * Update to idealized test cases to allow for intialization from an external sounding t_profile,q_profile,ws_profile = -1 to use this option with "input_sounding" in run directory * Example input sounding for ideal case initialization provided in top directory. Sounding must be of this form. * Fix to place input sounding data at half levels instead of full. * Added ability to turn off/on bubble random perturbations * Added type declaration * Added grid_type to write component Atmos type as passed from Atm%flagstruct * Removed some commented/unused code * Restore whitespace * Implemented deglon and deg_domain namelist flags for controlling idealized domain central longitude and domain size in lat/lon * Added documentation and a grid generation script for the idealized capability * Implemented the use of the existing do_coriolis ideal test flag to turn off coriolis. * Updates to interp_log and pressure computation for NISE test. * Small updates to NISE test structure * Remove extraneous code from debugging and testing * Remove do_radiation documentation * Added 'umove' and 'vmove' to ideal capability to create a moving domain effect. * Added comments to NISE test setup to improve user readability * Don't recompute f00 outside of init_ideal_periodic. Fix bug where rf array in rayleigh friction computation was iniitaliized but left empty if pressure never less than rf_cutoff. This bug was causing erroneous model-top winds and model crashes. * Moved user-definable idealized capability outside of test_cases.F90 and in to its own subroutine that is only compatible with UFS/GFS_PHYS. * Update ideal test documentation to account for code's new location. * Removed unused ideal namelist options * Add documentation to top of fv_ideal.F90 * Change logic for reading idealized namelist. fv_init_ideal now uses a separate namelist fv_ideal_nml. * Removed extraneous code from debugging/testing * Sixth reconciliation PR from production/RRFS.v1 (NOAA-EMC#365) * parallel IO enhancements from GDIT * turn ENABLE_PARALLELRESTART to OFF by default due to crashes on some UFS WM RT platforms * Updates for "Process Model" capability: Mostly renaming 'ideal' to 'processmodel' * Delete old docs * Fix output names in create_ideal_sfc_oro_input.py * Restore blank line * Move location of example input sounding to docs * fv_processmodel.F90: Fix z radius of thermal bubble * fv_control.F90 : Added GFS_PHYS flags as needed fv_processmodel.F90 : Added back the comment header with module usage and alphabetized --------- Co-authored-by: larissa.reames@noaa.gov <larissa.reames@noaa.gov> Co-authored-by: Grant Firl <grant.firl@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two files in fv3atm are updated following the fv3 dycore update PR#377 with fms 2021.03.
There is no impact on the results.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
The code changes have been tested in dell.
Dependencies
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs