Updates to use FMS 2021.03#374
Merged
Merged
Conversation
* io/FV3GFS_io.F90 updated to use fms2_io * atmos_model.F90 and ccpp/data/GFS_typefs.F90 updates to input_nml_file handling * atmos_cubed_sphere submodule updated
14 tasks
climbfuji
approved these changes
Aug 23, 2021
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Changes look good. We unfortunately do not have a restart test for suite FV3_GSD_v0 (which uses RUC LSM) in rt.conf, and on top of it we know that restart reproducibility for suites containing RUC is currently broken in develop (see issue ufs-community/ufs-weather-model#703). Therefore, we can't test if the code changes in this PR work for RUC LSM restarts until we bring the changes over to the NOAA-GSL forks/branches (where we do have a tests and the code reproduces in restart runs with RUC LSM).
junwang-noaa
approved these changes
Aug 25, 2021
DusanJovic-NOAA
approved these changes
Aug 25, 2021
Closed
bbakernoaa
pushed a commit
to bbakernoaa/fv3atm
that referenced
this pull request
Oct 20, 2025
Fix: Veritical Remapping on restarts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates fv3atm to use FMS 2021.03
Issue(s) addressed
Issue #373
Testing
These changes were tested on gaea by running the full RTS using rt.sh -k -e and comparisons against the current baseline all passed.
Are the changes covered by regression tests? N/A
Have the ufs-weather-model regression test been run? yes
On what platform? gaea
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Requires the latest hpc-stack which has FMS 2021.03 (tests were run with FMS_ROOT set to an FMS 2021.03 installation)
Requires stochastic_physics hash 2dfaec8ca47cea9397c1c1e6e6836ce1acaa421a
Do PRs in upstream repositories need to be merged first?
This does not have any requirements on any other repos at this point in time