Fix stochastic physics restart runs, remove rayleigh damping from all suite definition files#371
Merged
junwang-noaa merged 4 commits intoAug 19, 2021
Conversation
…e ca restart reproducibility
14 tasks
| endif initalize_stochastic_physics | ||
|
|
||
| if (GFS_Control%do_ca .and. is_initialized) then | ||
| if (GFS_Control%do_ca) then |
Contributor
There was a problem hiding this comment.
I suggest aligning this if block and the code underneath by shifting 2 spaces t the right.
Collaborator
Author
There was a problem hiding this comment.
Agree as well. @lisa-bengtsson I'll do as @SMoorthi-emc suggested.
Collaborator
Author
There was a problem hiding this comment.
Done, also aligned the endif so that the indentation matches.
SMoorthi-emc
approved these changes
Aug 18, 2021
DeniseWorthen
approved these changes
Aug 19, 2021
Collaborator
Author
|
@junwang-noaa I fixed the indentation, and all regression tests passed. Please review and approve if satisfied. Thanks! |
junwang-noaa
approved these changes
Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combines two changes:
stochastic_physics/stochastic_physics_wrapper.F90for reproducible restart runs, contributed by @lisa-bengtsson (see update and maintain coupled regression tests for prototype configurations ufs-community/ufs-weather-model#737 for more information)rayleigh_dampfrom all remaining suite definition files inccpp/suites/Issue(s) addressed
Fixes #340.
Testing
See ufs-community/ufs-weather-model#751.