Wrapper PR for "Update CCPP standard names for consistency (#337)"#356
Merged
junwang-noaa merged 6 commits intoJul 29, 2021
Merged
Conversation
11 tasks
DusanJovic-NOAA
approved these changes
Jul 28, 2021
junwang-noaa
approved these changes
Jul 28, 2021
Collaborator
Author
|
Ready for merging @junwang-noaa @DusanJovic-NOAA |
bbakernoaa
pushed a commit
to bbakernoaa/fv3atm
that referenced
this pull request
Oct 20, 2025
* STY: Make capitalization of Pa consistent. It should keep my unit software from thinking I measure pressure in picoannum * STY: Write millibar as mbar not mb. My unit software thinks the latter is millibarn, a unit of area for atomic scattering. This may help with CF compliance. * Replace pa with Pa in unit strings in nggps_diag My unit software reads "pa" as "picoannum", a unit of time on the order of microseconds, rather than as "pascals", the unit of pressure. * STY: Use Pa instead of pa as pressure units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is #337 updated with the latest code changes and all conflicts resolved. See #337 for a description.
Testing
See ufs-community/ufs-weather-model#719
Dependencies
NCAR/ccpp-physics#715
#356
ufs-community/ufs-weather-model#719