Wrapper PR for: Thompson inner loop, Thompson subcycling bugfix, remove snet from noah lsm, fix time dimension in restart files#350
Merged
DusanJovic-NOAA merged 20 commits intoJul 23, 2021
Conversation
…fix_thompson_pass_correct_timestep
…orlw, update logic to compute missing fields
…b.com/climbfuji/fv3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
…hompson_inner_loop_subcycling_bugfix_noah_bugfix
…ei-noaa/fv3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
…v3atm into thompson_inner_loop_subcycling_bugfix_noah_bugfix
climbfuji
changed the title
This was referenced Jul 22, 2021
climbfuji
requested review from
DusanJovic-NOAA,
HelinWei-NOAA,
RuiyuSun,
SMoorthi-emc and
junwang-noaa
junwang-noaa
approved these changes
Jul 22, 2021
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The code look good to me
SMoorthi-emc
approved these changes
Jul 22, 2021
DusanJovic-NOAA
approved these changes
Jul 23, 2021
Collaborator
Author
|
Ready to merge. |
This was referenced Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR combines many changes:
Issue(s) addressed
Fixes #348
Fixes #344
Fixes #335
Testing
See ufs-community/ufs-weather-model#702.
Dependencies
NCAR/ccpp-physics#702
#350
ufs-community/ufs-weather-model#702