Use nuopc labels in fv3cap. Refactor ModelAdvance in fv3cap.#330
Merged
DusanJovic-NOAA merged 17 commits intoJul 16, 2021
Conversation
Merged
14 tasks
Collaborator
|
Could we add this change to module_fcst_grid_comp.F90, which removes the requirement to have an empty data_table in the run directory. I've tested with control and 2 coupled configurations (one using data_override to apply runoff, one w/o) and all baselines pass. |
rmontuoro
reviewed
Jul 1, 2021
Comment on lines
-183
to
-185
| call NUOPC_CompFilterPhaseMap(gcomp, ESMF_METHOD_INITIALIZE, & | ||
| acceptStringList=(/"IPDv01p"/), rc=rc) | ||
| if (ESMF_LogFoundError(rcToCheck=rc, msg=ESMF_LOGERR_PASSTHRU, line=__LINE__, file=__FILE__)) return |
Collaborator
There was a problem hiding this comment.
Where is this statement going to end up?
There was a problem hiding this comment.
With the NUOPC semantic labels, that statement is no longer needed. No more IPDvXXpYY that the user needs to know about. Hurrah!
junwang-noaa
approved these changes
Jul 16, 2021
junwang-noaa
approved these changes
Jul 16, 2021
bbakernoaa
pushed a commit
to bbakernoaa/fv3atm
that referenced
this pull request
Oct 20, 2025
…iguous arrays (NOAA-EMC#330) * Update driver/fvGFS/atmosphere.F90: convert GFS_statein and GFS_stateout DDTs: use contiguous arrays instead of blocked data structures * Convert GFS_sfcprop DDT to contiguous arrays * Remove GFS_data=IPD_data from driver/fvGFS/atmosphere.F90 * After update from dev/emc, replace blocked IPD data types with contiguous GFS DDTs * Rename driver/fvGFS to driver/UFS and update CMakeLists.txt, docs/Doxyfile, driver/UFS/atmosphere.F90, model/fv_arrays.F90, tools/fv_nudge.F90; also resolve a previous merge conflict that was left in docs/Doxyfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Regression tests done on Hera (INtel and GNU)
Dependencies
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs
NOAA-GFDL/GFDL_atmos_cubed_sphere#113