Various CCPP PRs: change vertical dimension and long name of dku/dkt, UGWP bugfixes, LTP bugfixes, sfcsub update, framework update#291
Merged
junwang-noaa merged 7 commits intoApr 28, 2021
Conversation
…g flags for ugwpv1_gsldrag and GFS_DCNV_generic.F90
…dkt) and atmosphere_momentum_diffusivity (aka dku), update long names
…p-physics for code review and testing
climbfuji
changed the title
…lect_various_prs_20210422
…y/fv3atm into collect_various_prs_20210422
This was referenced Apr 26, 2021
13 tasks
… to match what is in the CCPP metadata
junwang-noaa
approved these changes
Apr 27, 2021
BinLiu-NOAA
approved these changes
Apr 27, 2021
Collaborator
BinLiu-NOAA
left a comment
BinLiu-NOAA
left a comment
There was a problem hiding this comment.
Changes look good to me.
climbfuji
force-pushed
the
collect_various_prs_20210422
branch
from
814eb92 to
7a6aeab
Compare
climbfuji
force-pushed
the
collect_various_prs_20210422
branch
from
7a6aeab to
d91d5e2
Compare
Collaborator
Author
|
This PR is ready to merge. |
DusanJovic-NOAA
pushed a commit
to ufs-community/ufs-weather-model
that referenced
this pull request
Apr 28, 2021
Various CCPP PRs as described in NOAA-EMC/ufsatm#291 Improvement and update for CI Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
dktanddkuIssue(s) addressed
See NCAR/ccpp-physics#641.
Testing
For regression testing, see ufs-community/ufs-weather-model#541
The changes in https://github.com/NCAR/ccpp-physics/pull/635/files modify the answers of all regression tests involving Thompson MP.
The changes in https://github.com/NCAR/ccpp-physics/pull/634/files modify the answers of all regression tests involving UGWP v1.
Dependencies
NCAR/ccpp-framework#368
NCAR/ccpp-physics#641
#291
ufs-community/ufs-weather-model#541