Skip to content

fix lam post uninitialied fields #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junwang-noaa merged 8 commits into from
Apr 20, 2021
Merged

fix lam post uninitialied fields #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a547885
fix lam post uninitialied fields
junwang-noaa Apr 6, 2021
017dc27
Merge remote-tracking branch 'upstream/develop' into lampost_fix
junwang-noaa Apr 9, 2021
d6eb43a
remove spval in openmp
junwang-noaa Apr 9, 2021
63c79ca
Merge remote-tracking branch 'upstream/develop' into lampost_fix
junwang-noaa Apr 12, 2021
cf62caf
add more uninitialized post fields
junwang-noaa Apr 15, 2021
2f03c08
update suite_FV3_GFS_v15_thompson_mynn_lam3km.xml to use mynnsfc_wrap…
junwang-noaa Apr 16, 2021
63b7e26
Merge remote-tracking branch 'upstream/develop' into lampost_fix
junwang-noaa Apr 16, 2021
ed4e265
Merge remote-tracking branch 'upstream/develop' into lampost_fix
junwang-noaa Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ccpp/suites/suite_FV3_GFS_v15_thompson_mynn_lam3km.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
</subcycle>
<!-- Surface iteration loop -->
<subcycle loop="2">
<scheme>sfc_diff</scheme>
<scheme>mynnsfc_wrapper</scheme>
<scheme>GFS_surface_loop_control_part1</scheme>
<scheme>sfc_nst_pre</scheme>
<scheme>sfc_nst</scheme>
Expand Down
44 changes: 35 additions & 9 deletions io/post_regional.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
use vrbls3d, only: t, q, uh, vh, wh, alpint, dpres, zint, zmid, o3, &
qqr, qqs, cwm, qqi, qqw, qqg, omga, cfr, pmid, &
q2, rlwtt, rswtt, tcucn, tcucns, train, el_pbl, &
pint, exch_h, ref_10cm
pint, exch_h, ref_10cm, extcof55, aextc55, u, v
use vrbls2d, only: f, pd, sigt4, fis, pblh, ustar, z0, ths, qs, twbs,&
qwbs, avgcprate, cprate, avgprec, prec, lspa, sno,&
cldefi, th10, q10, tshltr, pshltr, tshltr, albase,&
Expand Down Expand Up @@ -477,7 +477,8 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
up_heli_max03,up_heli_min03,rel_vort_max01, &
rel_vort_max, rel_vort_maxhy1, refd_max, &
refdm10c_max, u10max, v10max, wspd10max, sfcuxi, &
sfcvxi
sfcvxi, t10m, t10avg, psfcavg, akhsavg, akmsavg, &
albedo, tg
use soil, only: sldpth, sh2o, smc, stc
use masks, only: lmv, lmh, htm, vtm, gdlat, gdlon, dx, dy, hbm2, sm, sice
use ctlblk_mod, only: im, jm, lm, lp1, jsta, jend, jsta_2l, jend_2u, jsta_m,jend_m, &
Expand Down Expand Up @@ -641,7 +642,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
lspa(i,j) = SPVAL
th10(i,j) = SPVAL
q10(i,j) = SPVAL
albase(i,j) = SPVAL
albase(i,j) = 0.
Comment thread
junwang-noaa marked this conversation as resolved.
enddo
enddo

Expand Down Expand Up @@ -829,6 +830,34 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
enddo
enddo
!
!** temporary fix: initialize t10m, t10avg, psfcavg, akhsavg, akmsavg,
!** albedo, tg
!$omp parallel do default(none),private(i,j),shared(jsta_2l,jend_2u,im), &
!$omp& shared(t10m,t10avg,psfcavg,akhsavg,akmsavg,albedo,tg)
do j=jsta_2l,jend_2u
do i=1,im
t10m(i,j) = 0.
t10avg(i,j) = 0.
psfcavg(i,j) = 0.
akhsavg(i,j) = 0.
akmsavg(i,j) = 0.
albedo(i,j) = 0.
tg(i,j) = 0.
enddo
enddo
!$omp parallel do default(none),private(i,j,k),shared(jsta_2l,jend_2u,im,lm), &
!$omp& shared(extcof55,aextc55,u,v)
do k=1,lm
do j=jsta_2l,jend_2u
do i=1,im
extcof55(i,j,k) = 0.
aextc55(i,j,k) = 0.
u(i,j,k) = 0.
v(i,j,k) = 0.
enddo
enddo
enddo
!
!-----------------------------------------------------------------------------
! get post fields
!-----------------------------------------------------------------------------
Expand Down Expand Up @@ -1299,9 +1328,6 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
do i=ista, iend
mxsnal(i,j) = arrayr42d(i,j)
if (abs(arrayr42d(i,j)-fillValue) < small) mxsnal(i,j) = spval
if (mxsnal(i,j) /= spval) then
mxsnal(i,j) = mxsnal(i,j) * 0.01
endif
enddo
enddo
endif
Expand Down Expand Up @@ -1372,7 +1398,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
else
islope(i,j) = 0
endif
if (abs(arrayr42d(i,j)-fillValue) < small) islope(i,j) = spval
if (abs(arrayr42d(i,j)-fillValue) < small) islope(i,j) = 0
enddo
enddo
endif
Expand Down Expand Up @@ -1925,7 +1951,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
do i=ista, iend
if (arrayr42d(i,j) < spval) then
ivgtyp(i,j) = nint(arrayr42d(i,j))
if( abs(arrayr42d(i,j)-fillValue) < small) ivgtyp(i,j) = spval
if( abs(arrayr42d(i,j)-fillValue) < small) ivgtyp(i,j) = 0
else
ivgtyp(i,j) = 0
endif
Expand All @@ -1940,7 +1966,7 @@ subroutine set_postvars_regional(wrt_int_state,mpicomp,setvar_atmfile, &
do i=ista, iend
if (arrayr42d(i,j) < spval) then
isltyp(i,j) = nint(arrayr42d(i,j))
if( abs(arrayr42d(i,j)-fillValue) < small) isltyp(i,j) = spval
if( abs(arrayr42d(i,j)-fillValue) < small) isltyp(i,j) = 0
Comment thread
junwang-noaa marked this conversation as resolved.
else
isltyp(i,j) = 0
endif
Expand Down