release/public-v2: bit-for-bit reproducibility for regional runs when changing MPI decomposition#245
Merged
junwang-noaa merged 3 commits intoFeb 9, 2021
Conversation
…for code review and testing
This was referenced Feb 7, 2021
climbfuji
requested review from
DusanJovic-NOAA,
JamesAbeles-NOAA and
junwang-noaa
Collaborator
Author
|
@junwang-noaa @JamesAbeles-NOAA the GFDL_atmos_cubed_sphere PR was merged, I updated this fv3atm PR, please review and merge. Thanks! |
junwang-noaa
approved these changes
Feb 9, 2021
JamesAbeles-NOAA
approved these changes
Feb 9, 2021
JamesAbeles-NOAA
left a comment
JamesAbeles-NOAA
left a comment
There was a problem hiding this comment.
I approve. The changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR only updates the submodule pointer for GFDL_atmos_cubed_sphere for the changes in NOAA-GFDL/GFDL_atmos_cubed_sphere#68.
Issue(s) addressed
These PRs solve the "b4b reproducibility for regional runs on the ESG grid when changing the MPI decomposition" of issue ufs-community/ufs-weather-model#288.
Testing
For regression testing, see ufs-community/ufs-weather-model#409.
Dependencies
NOAA-GFDL/GFDL_atmos_cubed_sphere#68
#245
ufs-community/ufs-weather-model#409