Infrastructure improvements for radiation#193
Merged
DusanJovic-NOAA merged 9 commits intoNov 13, 2020
Conversation
Collaborator
|
The PR description is incomplete, can that be fixed please? Also, associated PRs: NCAR/ccpp-physics#514 For regression testing information, see ufs-community/ufs-weather-model#262 |
climbfuji
requested changes
Nov 6, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Straightforward!
Please update .gitmodules temporarily to point to your ccpp-physics fork and your branch master-ncar-f3e6761? Thanks.
climbfuji
approved these changes
Nov 12, 2020
DusanJovic-NOAA
approved these changes
Nov 13, 2020
junwang-noaa
approved these changes
Nov 13, 2020
Collaborator
|
Submodule pointer for ccpp-physics is correct, this can be merged. |
SamuelTrahanNOAA
pushed a commit
to SamuelTrahanNOAA/fv3atm
that referenced
this pull request
Jun 13, 2022
LarissaReames
pushed a commit
to LarissaReames/fv3atm
that referenced
this pull request
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains changes to accommodate improvements to both the RRTMG and RRTMGP radiation schemes.
The changes include new interstitial fields for use by the GP scheme, this includes new fields for configuration information.
Associated PRs:
NCAR/ccpp-physics#514
#193
ufs-community/ufs-weather-model#262
These changes were tested on Hera using Intel compilers. Existing RT's for the G scheme passed. New baselines for the GP RT's need to be created, for both v15p2 and