Bugfixes from public release#112
Merged
DusanJovic-NOAA merged 9 commits intoMay 8, 2020
Merged
Conversation
make variables using filename_base consistant in length
* set default calendar to gregorian * set default values of write_nemsioflip and write_fsyncflag to .true.
…on of code in CCPP
…-physics for code review and testing
Bring hotfixes from release/public-v1 back to master (CCPP changes)
junwang-noaa
approved these changes
May 7, 2020
climbfuji
reviewed
May 7, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Maybe I am doing something wrong, but I don't see the changes from my commits when I click on "all commits"? There should be several in ccpp/, one on GFS_physics_driver.F90, one in .gitmodules?
Collaborator
Ah, now I see, this is what you had to revert. I'll go and have a good look at the CCPP changes then. |
climbfuji
approved these changes
May 7, 2020
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Approved, but I do not understand why/how the regression tests failed when you merged my PR.
climbfuji
pushed a commit
to climbfuji/fv3atm
that referenced
this pull request
May 8, 2020
climbfuji
pushed a commit
to climbfuji/fv3atm
that referenced
this pull request
Oct 21, 2021
Updates to MYNN-EDMF in CCPP physics
SamuelTrahanNOAA
referenced
this pull request
in SamuelTrahanNOAA/fv3atm
Jun 13, 2022
* Add the option to run regression test with MULTI_GASES=Y * Add multi_gases CCPP regression test
LarissaReames
pushed a commit
to LarissaReames/fv3atm
that referenced
this pull request
Nov 17, 2023
Documentation and defaults changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick some bug fixes and cleanup commits from release/public-v1 branch.
Associated PRs:
ufs-community/ufs-weather-model#119