Add VM barrier and fix is_moving logic#1067
Merged
DusanJovic-NOAA merged 2 commits intoFeb 20, 2026
Merged
Conversation
add barrier at atm cap finalize force wait on wgc completion move the block of code in ufsatm where is_moving key is retrieved
22 tasks
Collaborator
|
Could we get reviews on this PR so that ufs-community/ufs-weather-model#3093 can be processed soon? |
DusanJovic-NOAA
approved these changes
Feb 18, 2026
dpsarmie
approved these changes
Feb 18, 2026
Collaborator
|
Testing on #3093 is complete, please continue with merging. Thank you. |
DusanJovic-NOAA
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a VmBarrier to the finalize of the UFSATM to ensure that the WCG has completed before executing the finalize.
Re-orders the sequence of initializing the WCG until after the is_moving info key has been retrieved.
Both fixes were found by @DusanJovic-NOAA
Issue(s) addressed
Testing
All UWM RTs pass. See related PR ufs-community/ufs-weather-model#3093
Dependencies
N/A