Bring in some HAFSv2 related UFSATM developments#1047
Conversation
|
Could we get reviews on this PR so that we can process WM parent PR 3014? |
|
@BinLiu-NOAA Please suggest reviewers for this PR |
|
@DusanJovic-NOAA, please consider inviting @wramstrom, @barlage, @dustinswales, @Qingfu-Liu as additional reviewers, as you see fit. Thanks! |
|
@BinLiu-NOAA We may skip to WM PR 3014 today if we can get the reviews for this PR. There seems to be a unit test issue with the PR we were originally going to process. @wramstrom, @barlage, @dustinswales, @Qingfu-Liu We would like to schedule the WM HAFS update PR ASAP. Is one (or more) of you available to review this PR today or tomorrow? |
dustinswales
left a comment
There was a problem hiding this comment.
This looks good to me, just some small changes requested.
Improve formating for some new added comments. Update submodule ccpp/physics.
|
@dustinswales Are there further changes required for this PR, or are you ready to approve? |
|
@BinLiu-NOAA Thanks for making the metadata changes! |
|
ufs-community/ccpp-physics#332 was merged. |
|
@BinLiu-NOAA Please revert .gitmodules and update the hashes for CCPP (525174d) and atmos_cubed_sphere (3e5db37). |
|
@gspetro-NOAA Submodules updated accordingly. Thanks! |
|
@DusanJovic-NOAA @BrianCurtis-NOAA This PR should be ready to merge as soon as we can get one more review. Now that Dustin has reviewed, is one of you willing to look it over? |
Description
This PR combines the following HAFS related developments and bring them back to UFSATM and related ufs-weather-model submodules.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Technical and retrospective/real-time-parallel testing were conducted with the UFS-HAFS hurricane application.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs