Skip to content

Bring in some HAFSv2 related UFSATM developments#1047

Merged
FernandoAndrade-NOAA merged 293 commits into
NOAA-EMC:developfrom
hafs-community:feature/hafsv2_sync
Feb 12, 2026
Merged

Bring in some HAFSv2 related UFSATM developments#1047
FernandoAndrade-NOAA merged 293 commits into
NOAA-EMC:developfrom
hafs-community:feature/hafsv2_sync

Conversation

@BinLiu-NOAA
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA BinLiu-NOAA commented Dec 12, 2025

Description

This PR combines the following HAFS related developments and bring them back to UFSATM and related ufs-weather-model submodules.

  • NoahMP LSM and sea ice related updates for HAFS moving nesting from @RongqianYang-NOAA, @barlage, and @wramstrom. Meanwhile, lots of contribution (discussions/diagnostics/debugging/testing) from @ChuankaiWang-NOAA, @yonghuiweng, ZhanZhang-NOAA, @helin.wei@noaa.gov, @fanglin.yang@noaa.gov, @BinLiu-NOAA as well.
    • Add snow layer and snow soil layer thickness to GFS_type.
    • Add checks for soil moisture for Noah MP.
    • Changes for distinguishing between new and old points for snow-related fields reset in moving nest physics.
    • Add leading_edge logical array to indicate which nest points have been interpolated. Needed for NOAH MP moving nest upgrades.
    • NOAHMP moving nest sea ice and cryosphere fixes and added variables tiice, tisfc, sncovr, fice, hice.
  • HAFS moving-nesting related 3D-IAU capability. (from @XuLu-NOAA)
  • Enable RRTMGP working with nesting (moving-nesting) configurations. (from @Qingfu-Liu, @dustinswales)
  • Introduce two Thompson MP related namelist options of fs_fac_rain and fs_fac_snow for adjustments of max terminal fall speeds of rain and snow. (from @WeiguoWang-NOAA)
  • Introduce two namelist options of cat_adj_deep and cat_adj_shal to adjust convective adjustment time in SASAS convection scheme. (from @JunghoonShin-NOAA)
  • Update HAFS moving-nesting internal tracker to output moving nest domain location to support the moving-nesting forecast restart capability. (from @BinLiu-NOAA)

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Technical and retrospective/real-time-parallel testing were conducted with the UFS-HAFS hurricane application.

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

BinLiu-NOAA and others added 30 commits July 24, 2023 21:14
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get reviews on this PR so that we can process WM parent PR 3014?

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA Please suggest reviewers for this PR

@BinLiu-NOAA
Copy link
Copy Markdown
Collaborator Author

BinLiu-NOAA commented Feb 3, 2026

@DusanJovic-NOAA, please consider inviting @wramstrom, @barlage, @dustinswales, @Qingfu-Liu as additional reviewers, as you see fit. Thanks!

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA We may skip to WM PR 3014 today if we can get the reviews for this PR. There seems to be a unit test issue with the PR we were originally going to process.

@wramstrom, @barlage, @dustinswales, @Qingfu-Liu We would like to schedule the WM HAFS update PR ASAP. Is one (or more) of you available to review this PR today or tomorrow?

Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, just some small changes requested.

Comment thread ccpp/data/GFS_typedefs.meta Outdated
Comment thread ccpp/data/GFS_typedefs.meta Outdated
Comment thread ccpp/data/GFS_typedefs.meta Outdated
Comment thread ccpp/data/GFS_typedefs.meta Outdated
Improve formating for some new added comments.
Update submodule ccpp/physics.
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@dustinswales Are there further changes required for this PR, or are you ready to approve?

@dustinswales
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA Thanks for making the metadata changes!

@grantfirl
Copy link
Copy Markdown
Collaborator

ufs-community/ccpp-physics#332 was merged.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@BinLiu-NOAA Please revert .gitmodules and update the hashes for CCPP (525174d) and atmos_cubed_sphere (3e5db37).

@BinLiu-NOAA
Copy link
Copy Markdown
Collaborator Author

@gspetro-NOAA Submodules updated accordingly. Thanks!

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@DusanJovic-NOAA @BrianCurtis-NOAA This PR should be ready to merge as soon as we can get one more review. Now that Dustin has reviewed, is one of you willing to look it over?

@FernandoAndrade-NOAA FernandoAndrade-NOAA merged commit c9199f5 into NOAA-EMC:develop Feb 12, 2026
8 checks passed
This was referenced Feb 13, 2026
@BinLiu-NOAA BinLiu-NOAA deleted the feature/hafsv2_sync branch February 14, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.