Skip to content

Replace 1038: Fix time-averaged radiation variables#1043

Merged
DusanJovic-NOAA merged 3 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/fix_time_averaged_radiation
Dec 10, 2025
Merged

Replace 1038: Fix time-averaged radiation variables#1043
DusanJovic-NOAA merged 3 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/fix_time_averaged_radiation

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

Information copied from #1038

Description

This PR fixes some of the UFS-ATM issue discussed in ufs-weather-model issues #1767.
ufs-community/ufs-weather-model#1767
The problem in retro tests has been discussed in detail in GFS issues #43:
NOAA-EMC/GFS#43 (comment)
@JongilHan66 noticed the time averaged cloud cover, which should range from 0-100%, only range across 0-4% in his experiment based on the retrotest16update branch . Abnormal ranges happen to all time averaged cloud cover, and related radiative fluxes. The instantaneous cloud covers and radiative fluxes are fine. The issue is from the UWM and exists in the sfc history files.
There are two different problems related to the radiation fields, one is the instantaneous values used for the coupling (the radiation time step is 3600s, and the physics time step or dynamic time steps are much smaller, for example 360s or 720s), so the coupling need to estimate the radiation flux at the coupling time step which needs to extrapolate the radiation fluxes from the earlier radiation calculation. This extrapolation is not a bug, but not accurate. The second problem is the time-averaged calculation which is a bug. The time-averaged quantities related to the radiation variables are wrong in current UFS community repository.
As Fanglin mentioned in his e-mail:
"This outstanding issue has been affecting us for some time. A number of people have been involved in the discussion or contributed code changes in the past few years. Thank you, in particular, Denise for bringing the issue to everyone's attention in the first place, Grant, for taking this over after Larissa's departure, Dusan, for providing the working solution, and Qingfu, for the testing and confirmation."

The changes of answers are expected from this PR.

Issue(s) addressed

Testing

The code changes have been tested in ufs-weather-model regression tests, and the results have been plotted/diagnosed for all the radiation related variables.
The code updates change the regression test baseline if the output interval is smaller than the averaging interval, otherwise, the code will not change the test baseline.
(no regression test log files since I have not run all the baseline tests. Hope someone can help to run the regression tests and provide the log files)

Dependencies

No dependency

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing for WM parent PR 3004 completed successfully. We can proceed with merging this PR.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 63d16a3 into NOAA-EMC:develop Dec 10, 2025
2 of 5 checks passed
@DeniseWorthen DeniseWorthen deleted the feature/fix_time_averaged_radiation branch April 24, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants