Replace 1038: Fix time-averaged radiation variables#1043
Merged
DusanJovic-NOAA merged 3 commits intoDec 10, 2025
Merged
Conversation
…o feature/fix_time_averaged_radiation
22 tasks
RuiyuSun
approved these changes
Dec 9, 2025
DusanJovic-NOAA
approved these changes
Dec 9, 2025
Collaborator
|
Testing for WM parent PR 3004 completed successfully. We can proceed with merging this PR. |
BrianCurtis-NOAA
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information copied from #1038
Description
This PR fixes some of the UFS-ATM issue discussed in ufs-weather-model issues #1767.
ufs-community/ufs-weather-model#1767
The problem in retro tests has been discussed in detail in GFS issues #43:
NOAA-EMC/GFS#43 (comment)
@JongilHan66 noticed the time averaged cloud cover, which should range from 0-100%, only range across 0-4% in his experiment based on the retrotest16update branch . Abnormal ranges happen to all time averaged cloud cover, and related radiative fluxes. The instantaneous cloud covers and radiative fluxes are fine. The issue is from the UWM and exists in the sfc history files.
There are two different problems related to the radiation fields, one is the instantaneous values used for the coupling (the radiation time step is 3600s, and the physics time step or dynamic time steps are much smaller, for example 360s or 720s), so the coupling need to estimate the radiation flux at the coupling time step which needs to extrapolate the radiation fluxes from the earlier radiation calculation. This extrapolation is not a bug, but not accurate. The second problem is the time-averaged calculation which is a bug. The time-averaged quantities related to the radiation variables are wrong in current UFS community repository.
As Fanglin mentioned in his e-mail:
"This outstanding issue has been affecting us for some time. A number of people have been involved in the discussion or contributed code changes in the past few years. Thank you, in particular, Denise for bringing the issue to everyone's attention in the first place, Grant, for taking this over after Larissa's departure, Dusan, for providing the working solution, and Qingfu, for the testing and confirmation."
The changes of answers are expected from this PR.
Issue(s) addressed
In coupled configs, SW exported by ATM has odd time-dependence ufs-community/ufs-weather-model#1767
error in the averaged cloud cover and radiative fluxes GFS#43 (comment)
Testing
The code changes have been tested in ufs-weather-model regression tests, and the results have been plotted/diagnosed for all the radiation related variables.
The code updates change the regression test baseline if the output interval is smaller than the averaging interval, otherwise, the code will not change the test baseline.
(no regression test log files since I have not run all the baseline tests. Hope someone can help to run the regression tests and provide the log files)
Dependencies
No dependency