Skip to content

GFDL_atmos_cubed_sphere fix for SKEB in hydrostatic mode#1012

Merged
DusanJovic-NOAA merged 11 commits into
NOAA-EMC:developfrom
pjpegion:skeb_hydro
Dec 23, 2025
Merged

GFDL_atmos_cubed_sphere fix for SKEB in hydrostatic mode#1012
DusanJovic-NOAA merged 11 commits into
NOAA-EMC:developfrom
pjpegion:skeb_hydro

Conversation

@pjpegion
Copy link
Copy Markdown
Collaborator

Description

Fix is in GFDL_atmos_cubed_sphere, this PR only updates the submodule pointer for the PR.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

@pjpegion pjpegion changed the title update submodule to my branch GFDL_atmos_cubed_sphere fix for SKEB in hydrostatic mode Sep 23, 2025
@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get this PR reviewed so that parent WM PR 2997 can be scheduled for the Commit Queue?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Could we get this PR reviewed so that parent WM PR 2997 can be scheduled for the Commit Queue?

Looking for reviews on this PR. Thanks!

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Dec 11, 2025

@pjpegion Could you update the hashes for this PR and atmos_cubed_sphere?

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

gspetro-NOAA commented Dec 15, 2025

@DusanJovic-NOAA @jkbk2004 Could you review this subcomponent PR or tag someone who should review? We are looking to process WM parent PR 2997 this week but are still missing reviews on the UFSATM sub-PR.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

@pjpegion The atmos_sphere_cubed sub-PR has been merged. Please update .gitmodules on this PR and update the hash to 87936f8.

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

This PR is ready to merge. WM testing completed successfully for parent PR 2997, the atmos_cubed_sphere sub-PR has been merged, and Phil has reverted .gitmodules and updated the hash.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 2eba8e7 into NOAA-EMC:develop Dec 23, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants