GFDL_atmos_cubed_sphere fix for SKEB in hydrostatic mode#1012
Merged
Conversation
33 tasks
33 tasks
Collaborator
|
Could we get this PR reviewed so that parent WM PR 2997 can be scheduled for the Commit Queue? |
Collaborator
Looking for reviews on this PR. Thanks! |
Collaborator
|
@pjpegion Could you update the hashes for this PR and atmos_cubed_sphere? |
Collaborator
|
@DusanJovic-NOAA @jkbk2004 Could you review this subcomponent PR or tag someone who should review? We are looking to process WM parent PR 2997 this week but are still missing reviews on the UFSATM sub-PR. |
DusanJovic-NOAA
approved these changes
Dec 15, 2025
BrianCurtis-NOAA
approved these changes
Dec 15, 2025
Collaborator
Collaborator
|
This PR is ready to merge. WM testing completed successfully for parent PR 2997, the atmos_cubed_sphere sub-PR has been merged, and Phil has reverted .gitmodules and updated the hash. |
BrianCurtis-NOAA
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix is in GFDL_atmos_cubed_sphere, this PR only updates the submodule pointer for the PR.
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs