Skip to content

Add tracing instrumentation to nuopc driver#1009

Merged
DusanJovic-NOAA merged 17 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:ufs_tracing
Jan 20, 2026
Merged

Add tracing instrumentation to nuopc driver#1009
DusanJovic-NOAA merged 17 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:ufs_tracing

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Collaborator

Description

This PR adds calls to ufs tracing routines that will create a trace file which can then be visualized, which is found to be useful in identifying various performance issues.

See ufs-weather-model issue ufs-community/ufs-weather-model#2883

Added calls are not used by default, unless build option (-DUFS_TRACING=ON) is specified when building the ufs-weather-model.

No baseline changes are expected.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@gspetro-NOAA
Copy link
Copy Markdown
Collaborator

Testing on WM PR 2884 has completed successfully. This PR can be merged.

@DusanJovic-NOAA DusanJovic-NOAA merged commit 3c47d5b into NOAA-EMC:develop Jan 20, 2026
8 checks passed
@DusanJovic-NOAA DusanJovic-NOAA deleted the ufs_tracing branch January 21, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants