Add RRFS fire weather grid: forecast task

[BenjaminBlake-NOAA]

DESCRIPTION OF CHANGES:

This is the third PR for adding the RRFS fire weather grid to rrfs-workflow. In this PR, the run_fcst task was tested and completes successfully. There is one outstanding issue related to the CCPP suite xml file (in bold below) which may need to be resolved before this PR is merged. Some additional comments about this PR are listed below:

• The config.sh file is updated to point to staged data in UFS_SRW_App/develop/input_model_data.
• A new namelist template file is added to the parm directory - input.nml.RRFSFW. When the set_namelist.py script is called within generate_FV3LAM_wflow.sh, the namelist is modified without the use of a yaml file because only one CCPP suite needs to be supported for RRFSFW at this time - FV3_HRRR_gf.
• Currently in the RRFSFW real-time parallel, fractional vegetation and soil information is added to the orography files at the beginning of the forecast task. This logic has been moved to the end of the make_sfc_climo task.
• In order to run the RRFSFW forecast without gravity wave drag, the suite_FV3_HRRR_gf.xml file needs to be modified prior to compiling the ufs-weather-model code. Since suite_FV3_HRRR_gf.xml is part of the ufs-weather-model repository, I do not know the best way to handle this. Maybe we need to add another CCPP xml file to the ufs-weather-model repo?

TESTS CONDUCTED:

• On machines/platforms:

• WCOSS2

• Hera

• Orion

• Jet

• Test cases:

• Non-DA engineering test
• DA engineering test
• Other sample scripts: ush/sample_configs/RRFSFW/config.sh_RRFSFW

ISSUE:

• Continues to address issue Add fire weather functionality into rrfs-workflow #15

CONTRIBUTORS (optional):

[chan-hoo]

@BenjaminBlake-NOAA, regarding the ccpp suite file for FW, I agree with you. I think the file like 'suite_FV3_HRRR_gf_fireweather.xml' should be eventually added to the ufs weather model. Until then, you can add the file to the 'parm' directory and add a temporary fix (replacement) command to the build script app_build.sh with an option flag "--fw". If you need my help, please let me know.

[BenjaminBlake-NOAA]

@chan-hoo Sure that's a good suggestion for now. I will try doing that and let you know if I run into issues.

[chan-hoo]

@BenjaminBlake-NOAA, I failed to run your sample case. I got the following error message:

FATAL ERROR: 
ERROR:
  From function:  "generate_FV3LAM_wflow"
  In file:  "generate_FV3LAM_wflow.sh"
  Full path to file:  "/lfs/h2/emc/lam/noscrub/chan-hoo.jeon/rrfs_fw/rrfs-workflow/ush/generate_FV3LAM_wflow.sh"
Call to python script set_namelist.py to generate an FV3 namelist file
failed.  Parameters passed to this script are:
  Full path to base namelist file:
    FV3_NML_BASE_SUITE_FP = "/lfs/h2/emc/lam/noscrub/chan-hoo.jeon/rrfs_fw/rrfs-workflow/parm/input.nml.RRFSFW"
  Full path to output namelist file: 
    FV3_NML_FP = "/lfs/h2/emc/lam/noscrub/chan-hoo.jeon/rrfs_fw/expt_dirs/test_firewx/input.nml"

[BenjaminBlake-NOAA]

@chan-hoo I got a similar error but I thought I resolved it. Let me test generating the workflow again, maybe I forgot to commit a change.

[BenjaminBlake-NOAA]

@chan-hoo There was an extra blank space after a '\' character and that caused the failure. I must have added an extra space when committing the changes. I'm confused why that would matter but maybe the formatting is very particular. I just tested it successfully and committed the updated version of generate_FV3LAM_wflow.sh to my firewx branch. Let me know if it works for you now. Thanks!

[chan-hoo]

@BenjaminBlake-NOAA, is this the last PR for RRFS_FW?

[BenjaminBlake-NOAA]

@chan-hoo There will be one more PR after this one for the post-processing job. As part of that PR, a new source code from the NAM called firewx_gridspecs is required. Eric Rogers modified that code and called it rrfsfw_firewxspecs. Perhaps it can be added to RRFS utils.

[chan-hoo]

@BenjaminBlake-NOAA, got it. Thanks. Approving now.

[MatthewPyle-NOAA]

Just one small comment about the SDF needed for rrfsfw.

[MatthewPyle-NOAA]

Ben - is this the item you need to get into the FV3 repository? If so, I recommend not waiting to start that process. (But will approve it).

[BenjaminBlake-NOAA]

Yes that's correct. I assume this is the repository I would open a PR to: https://github.com/NOAA-EMC/fv3atm

[MatthewPyle-NOAA]

Yes. Unfortunately looks like Jili's PR to add 5 SDFs in that repository is close to being merged - would have been good to tack this one onto that.