Skip to content

Update CHGRP_RSTPROD check for MAKE_NSSTBUFR#100

Merged
KateFriedman-NOAA merged 6 commits into
NOAA-EMC:dev/gfsv17from
TaylorRoper-NOAA:update/norstprod_cloud
May 7, 2025
Merged

Update CHGRP_RSTPROD check for MAKE_NSSTBUFR#100
KateFriedman-NOAA merged 6 commits into
NOAA-EMC:dev/gfsv17from
TaylorRoper-NOAA:update/norstprod_cloud

Conversation

@TaylorRoper-NOAA
Copy link
Copy Markdown

@TaylorRoper-NOAA TaylorRoper-NOAA commented May 5, 2025

Reorganized MAKE_NSSTBUFR block to check CHGRP_RSTPROD. Since the restricted data is not used on the cloud at this time, CHGRP_RSTPROD is defaulted to NO for cloud environments. Previously, the NSST buffer file was only created if chgrp rstprod command is successful causing the NSST buffer file to be empty when made on the cloud using unrestricted data.

Tested this change within the prep steps of the global-workflow C96_atm3DVar test on Hera (with CHGRP_RSTPROD='YES') and NOAA cloud AWS (with CHGRP_RSTPROD='YES' to check null file is created in place of NSST buffer file when chgrp rstprod command fails and with CHGRP_RSTPROD='NO'). Associated log files and resulting NSST buffer files for both environments can be found on Hera in /scratch1/BMC/qosap/Taylor.Roper/shared (labeled *.hera and *.cloud respectively).

Resolves #101

Comment thread scripts/exglobal_makeprepbufr.sh Outdated
Comment thread scripts/exglobal_makeprepbufr.sh Outdated
@ilianagenkova
Copy link
Copy Markdown
Contributor

FWIW, NCO/Operations doesn't like files to be overwritten in $COMROOT, so any nsstbufr processing should be done & dusted before copying the file to $COMROOT.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

FWIW, NCO/Operations doesn't like files to be overwritten in $COMROOT, so any nsstbufr processing should be done & dusted before copying the file to $COMROOT.

Thanks for the feedback @ilianagenkova ! @TaylorRoper-NOAA please make sure the permissions are set on the nsstbufr file before it gets moved to COM, thanks!

@TaylorRoper-NOAA
Copy link
Copy Markdown
Author

@KateFriedman-NOAA Please look at the changes I made. I restructured to apply permissions to nsstbufr before copying to COM using cp -p. nsstbufr gets created only within the MAKE_NSSTBUFR block if CHGRP_RSTPROD='NO' or if the chgrp rstprod command fails.

Comment thread scripts/exglobal_makeprepbufr.sh Outdated
Comment thread scripts/exglobal_makeprepbufr.sh Outdated
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @TaylorRoper-NOAA !

Comment thread scripts/exglobal_makeprepbufr.sh
Copy link
Copy Markdown
Contributor

@ilianagenkova ilianagenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Taylor.

@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

Thanks for your review and feedback @ilianagenkova ! I'll now merge this PR into the dev/gfsv17 branch. Thanks for your changes @TaylorRoper-NOAA !

@KateFriedman-NOAA KateFriedman-NOAA merged commit c8b6f5d into NOAA-EMC:dev/gfsv17 May 7, 2025
@TaylorRoper-NOAA TaylorRoper-NOAA deleted the update/norstprod_cloud branch May 7, 2025 20:54
aerorahul pushed a commit to NOAA-EMC/global-workflow that referenced this pull request May 14, 2025
This PR enables running prep jobs on AWS. This required supporting
`obsproc` and `prepobs` on the cloud
(NOAA-EMC/obsproc#99 and
NOAA-EMC/prepobs#43) and deciding on placement
of `BASE_GIT` directory which houses `obsproc` and `prepobs`. `BASE_GIT`
is proposed to be `/contrib/git` on AWS (and other NOAA CSPs), and
`obsproc` and `prepobs` have been cloned and installed in `/contrib/git`
on the EPIC's AWS `/contrib` filesystem for future CI testing. The obs
data used was made available on AWS via #3494, and the `DMPDIR` is
defaulted to `/bucket/dump` or user-defined via `DATA_MOUNT` for AWS.
Since restricted data is not yet supported on NOAA CSPs, AWS defaults
are updated to include `CHGRP_RSTPROD='NO'` and `MAKE_NSSTBUFR='YES'`.
Updating `CHGRP_RSTPROD` is necessary since NSST buffer files are
assumed in `obsproc` to consist of restricted data and are overwritten
as empty when `chgrp rstprod` fails. Allowing making the NSST buffer
file on the fly with `CHGRP_RSTPROD='NO'` was done via
NOAA-EMC/obsproc#100.

Resolves #3497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants