Add rhonewsn1 to nuopc and to the NOAH MP driver and source code#4
Conversation
|
@barlage @uturuncoglu Could you review this PR at your convenience? |
|
@ChunxiZhang-NOAA I have a meeting all day but I'll look at it today and maybe test it. |
|
@uturuncoglu No problem. Thank you! |
uturuncoglu
left a comment
There was a problem hiding this comment.
We need to clarify how we handle this new argument in component version of the model before merging this. So, we also need input from @barlage
|
@ChunxiZhang-NOAA @BrianCurtis-NOAA This is merged now. Thanks for putting this. |
|
@uturuncoglu Thanks for merging it. The merge is supposed to be done AFTER all ufs-weather-model regression tests on different platforms passed. But I think it is OK for now unless some bugs caught later from the regression tests. |
|
@ChunxiZhang-NOAA I was thinking that that is already done and you are waiting for this merge. Anyway, if you see any issue we could fix it. I have already test the datm+land outside of the UFS and it was fine. I am not sure about other RTs. |
|
@uturuncoglu Sure, I will let you know if there is any issue. And yes, the RT test on Hera was successful. The chance to fail on other platforms is very low. |
A variable precip ice density, rhonewsn1, is passed into the driver and then assigned to prcpiceden. The array prcpiceden is used in the LSM if the namelist option, iopt_snf = 5 and exticeden = T. The flag exticeden is set to T if a user wants to compute the variable precip ice density.
This PR is connected with the following PRs:
Depends on Winterwx NOAA-EMC/ufsatm#614
Depends on Winterwx ufs-community/ccpp-physics#30
Six new winter weather diagnostics, new precip ice density for RUC, NOAH and NOAH MP LSM, and rename nsradar_reset ufs-community/ufs-weather-model#1529