Skip to content

Replace icplocn2atm (integer) with use_oceanuv (logical) #17

Merged
uturuncoglu merged 2 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/rename_icplocn2atm
Sep 17, 2025
Merged

Replace icplocn2atm (integer) with use_oceanuv (logical) #17
uturuncoglu merged 2 commits into
NOAA-EMC:developfrom
DeniseWorthen:feature/rename_icplocn2atm

Conversation

@DeniseWorthen
Copy link
Copy Markdown

Updates ccpp/sfc_diff.f to change integer icplocn2atm to logical use_oceanuv.

Required by ufs-community/ufs-weather-model#2867

@DeniseWorthen
Copy link
Copy Markdown
Author

@barlage Can you approve this PR?

@DeniseWorthen
Copy link
Copy Markdown
Author

@uturuncoglu Would you please review/approve this PR?

Copy link
Copy Markdown
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@uturuncoglu
Copy link
Copy Markdown
Collaborator

@DeniseWorthen let me know ıf you want me to merge.

@DeniseWorthen
Copy link
Copy Markdown
Author

@uturuncoglu Thanks. I'll ping you when testing is done and we're ready to merge.

@uturuncoglu
Copy link
Copy Markdown
Collaborator

@DeniseWorthen Okay. Sure.

@DeniseWorthen
Copy link
Copy Markdown
Author

@uturuncoglu We're ready to merge this PR; thanks!

@uturuncoglu uturuncoglu merged commit 8fe108a into NOAA-EMC:develop Sep 17, 2025
@uturuncoglu
Copy link
Copy Markdown
Collaborator

@DeniseWorthen done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants