Removal of goto statements#16
Merged
uturuncoglu merged 5 commits intoOct 2, 2025
Merged
Conversation
Author
|
@uturuncoglu would you mind taking a look at this PR when you get a chance? It'll need to be approved and merged as part of a UFS PR sometime this week. Thanks! |
22 tasks
uturuncoglu
approved these changes
Sep 29, 2025
Collaborator
|
@dpsarmie It looks good to me. Let me know when you are ready to merge. |
|
Testing on #2913 is complete, please continue with merging, thank you. |
Collaborator
|
@FernandoAndrade-NOAA It is merged. Please do not forget to update component version of NoahMP. Both CCPP version and component version needs to use same version to prevent conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a requirement from NCO to remove deprecated
gotostatements in the GFS package (including submodules). There were only 3gotostatements in the noahmp code and this PR removes those statements and reworks the code to keep the same logic.Also a write statement was removed. This statement was being triggered if land IAU was active. This created a large amount of unnecessary lines to be written to stdout. (ex. GDAS case went from ~20k lines to ~2 million). Since the line does not seem to be a warning or error, we decided to remove it instead of writing it when on the master PE.
This code was tested against the regression test suite in the UFS and produced no changes to baselines as expected, but it should be noted that not all of the RTs use the LSM.