Skip to content

Removal of goto statements#16

Merged
uturuncoglu merged 5 commits into
NOAA-EMC:developfrom
dpsarmie:fix/remove_goto_statements
Oct 2, 2025
Merged

Removal of goto statements#16
uturuncoglu merged 5 commits into
NOAA-EMC:developfrom
dpsarmie:fix/remove_goto_statements

Conversation

@dpsarmie
Copy link
Copy Markdown

@dpsarmie dpsarmie commented Aug 12, 2025

There is a requirement from NCO to remove deprecated goto statements in the GFS package (including submodules). There were only 3 goto statements in the noahmp code and this PR removes those statements and reworks the code to keep the same logic.

Also a write statement was removed. This statement was being triggered if land IAU was active. This created a large amount of unnecessary lines to be written to stdout. (ex. GDAS case went from ~20k lines to ~2 million). Since the line does not seem to be a warning or error, we decided to remove it instead of writing it when on the master PE.

This code was tested against the regression test suite in the UFS and produced no changes to baselines as expected, but it should be noted that not all of the RTs use the LSM.

@dpsarmie
Copy link
Copy Markdown
Author

@uturuncoglu would you mind taking a look at this PR when you get a chance? It'll need to be approved and merged as part of a UFS PR sometime this week. Thanks!

@uturuncoglu
Copy link
Copy Markdown
Collaborator

@dpsarmie It looks good to me. Let me know when you are ready to merge.

@FernandoAndrade-NOAA
Copy link
Copy Markdown

Testing on #2913 is complete, please continue with merging, thank you.

@uturuncoglu uturuncoglu merged commit a0363fd into NOAA-EMC:develop Oct 2, 2025
@uturuncoglu
Copy link
Copy Markdown
Collaborator

@FernandoAndrade-NOAA It is merged. Please do not forget to update component version of NoahMP. Both CCPP version and component version needs to use same version to prevent conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants