Skip to content

Add 'rca' variable to noahmpdrv_run interface for CCPP/physics PR#205#10

Merged
jkbk2004 merged 3 commits into
NOAA-EMC:developfrom
grantfirl:combo_20240503
May 17, 2024
Merged

Add 'rca' variable to noahmpdrv_run interface for CCPP/physics PR#205#10
jkbk2004 merged 3 commits into
NOAA-EMC:developfrom
grantfirl:combo_20240503

Conversation

@grantfirl
Copy link
Copy Markdown

@grantfirl grantfirl commented May 9, 2024

Needed for ufs-community/ufs-weather-model#2264 and ufs-community/ccpp-physics#205

Add rca variable to NUOPC cap for noahmpdrv_run().

@grantfirl grantfirl marked this pull request as ready for review May 10, 2024 14:19
@DeniseWorthen
Copy link
Copy Markdown

@uturuncoglu @barlage Could one of you please review this PR?

@barlage
Copy link
Copy Markdown
Collaborator

barlage commented May 13, 2024

@DeniseWorthen I believe there is some additional testing being performed within ccpp-physics

@grantfirl @uturuncoglu @drnimbusrain

@drnimbusrain
Copy link
Copy Markdown

drnimbusrain commented May 13, 2024 via email

@grantfirl
Copy link
Copy Markdown
Author

@drnimbusrain @DeniseWorthen @barlage @uturuncoglu This has been updated to reflect the latest changes from @drnimbusrain. I believe that it is ready for final review at this point.

Copy link
Copy Markdown
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@barlage
Copy link
Copy Markdown
Collaborator

barlage commented May 16, 2024

@grantfirl are the noahmpdrv updates in ccpp-physics 205 ready to go for this PR also?

@barlage
Copy link
Copy Markdown
Collaborator

barlage commented May 16, 2024

@grantfirl sorry, I think I see the parameter limit changes now

@grantfirl
Copy link
Copy Markdown
Author

@grantfirl sorry, I think I see the parameter limit changes now

Yep, the changes here should be identical to ufs-community/ccpp-physics#205

@jkbk2004
Copy link
Copy Markdown
Collaborator

Tests are done ok at ufs-community/ufs-weather-model#2264. We can merge this pr.

@jkbk2004 jkbk2004 merged commit ec38ea3 into NOAA-EMC:develop May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants