Skip to content

Yaml updates for use with updated GDASApp submodules#8

Merged
CoryMartin-NOAA merged 4 commits into
developfrom
feature/submodules
Jun 5, 2024
Merged

Yaml updates for use with updated GDASApp submodules#8
CoryMartin-NOAA merged 4 commits into
developfrom
feature/submodules

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

GDASApp PR #1123 updates the hashes for select JEDI repositories. The updated hashes require yaml updates.

  • add static keyword to gsi covariance
  • update names used for radiance bias correction terms

Resolves #6

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

NOTE This PR is opened as a draft since merger of the changes in this PR into jcb-gdas develop needs to be coordinated with GDASApp PR #1123.

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 22, 2024
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review May 24, 2024 01:22
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft May 24, 2024 01:24
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review June 4, 2024 15:03
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Moving forward with GDASApp PR #1123. Therefore, mark this PR as Ready for review

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

@CoryMartin-NOAA & @danholdaway , merger of this PR into jcb-gdas develop is required to fully close out GDASApp PR #1123.

Once this PR is in develop, I will update the jcb-gdas hash in PR #1123.

Copy link
Copy Markdown
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and necessary for the new bias correction predictor names

@CoryMartin-NOAA CoryMartin-NOAA merged commit 0d66231 into develop Jun 5, 2024
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/submodules branch June 5, 2024 15:34
danholdaway added a commit that referenced this pull request Jun 6, 2024
* develop:
  Yaml updates for use with updated GDASApp submodules (#8)
danholdaway pushed a commit that referenced this pull request Nov 14, 2024
Does the same thing as jcb-algorithms PR
[#8](NOAA-EMC/jcb-algorithms#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update yamls to work with updated GDASApp JEDI submodules

3 participants