Add separate salt and temp configs for argo#78
Merged
Conversation
2 tasks
guillaumevernieres
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Feb 27, 2025
…post-BUFR observations (#1504) # Description - Implements modifications to concatinate IODA observation files converted from BUFR format from multiple cycles in a window to a single file for the current cycle - Separates temperature from salinity observations in Argo floats so that they are delivered to obs under COMROOT as two separate IODA files Tested with `C48mx500_3DVarAOWCDA` and `C48mx500_hybAOWCDA` on Hera with NOAA-EMC/jcb-gdas#78 and obs spaces enabled in `OBS_LIST`. Aside from passing test, files `gdas.t00z.insitu_salt_profile_argo.2021032500.nc4` and `gdas.t00z.insitu_temp_profile_argo.2021032500.nc4` are delivered to `gdas.20210325/00/obs` bearing plausible-looking values for salt and temperature respectively, and seem to be assimilated. No quantitative analysis has been performed on these obs. # Companion PRs Not necessary for merging and passing ctests, but if new obs spaces get included the following is needed: NOAA-EMC/jcb-gdas#78 # Issues Mostly resolves #1132 # Automated CI tests to run in Global Workflow - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
guillaumevernieres
approved these changes
Feb 27, 2025
Contributor
guillaumevernieres
left a comment
guillaumevernieres
left a comment
There was a problem hiding this comment.
Thanks @AndrewEichmann-NOAA
danholdaway
added a commit
that referenced
this pull request
Mar 26, 2025
* develop: Add sample conventional surface pressure template for generating summary stats (#85) Revert "Add aerosol bias correction to yaml templates" (#84) JEDI-based ensemble recentering and analysis calculation and native grid increments (#72) Add aerosol bias correction to yaml templates (#83) Set up the reject list in observation chronicle for GTS synoptic snow depth data (#79) Add separate salt and temp configs for argo (#78) Add marine j2 yamls for tropical moorings and surface drifters (#81) Update for missing snow files (#76) Quick Filename Fix for Stats YAMLs (#80) Remove the ens B from the marine hybrid B (#73)
jspsl
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Mar 26, 2025
…post-BUFR observations (#1504) # Description - Implements modifications to concatinate IODA observation files converted from BUFR format from multiple cycles in a window to a single file for the current cycle - Separates temperature from salinity observations in Argo floats so that they are delivered to obs under COMROOT as two separate IODA files Tested with `C48mx500_3DVarAOWCDA` and `C48mx500_hybAOWCDA` on Hera with NOAA-EMC/jcb-gdas#78 and obs spaces enabled in `OBS_LIST`. Aside from passing test, files `gdas.t00z.insitu_salt_profile_argo.2021032500.nc4` and `gdas.t00z.insitu_temp_profile_argo.2021032500.nc4` are delivered to `gdas.20210325/00/obs` bearing plausible-looking values for salt and temperature respectively, and seem to be assimilated. No quantitative analysis has been performed on these obs. # Companion PRs Not necessary for merging and passing ctests, but if new obs spaces get included the following is needed: NOAA-EMC/jcb-gdas#78 # Issues Mostly resolves #1132 # Automated CI tests to run in Global Workflow - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
DavidNew-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
…post-BUFR observations (#1504) # Description - Implements modifications to concatinate IODA observation files converted from BUFR format from multiple cycles in a window to a single file for the current cycle - Separates temperature from salinity observations in Argo floats so that they are delivered to obs under COMROOT as two separate IODA files Tested with `C48mx500_3DVarAOWCDA` and `C48mx500_hybAOWCDA` on Hera with NOAA-EMC/jcb-gdas#78 and obs spaces enabled in `OBS_LIST`. Aside from passing test, files `gdas.t00z.insitu_salt_profile_argo.2021032500.nc4` and `gdas.t00z.insitu_temp_profile_argo.2021032500.nc4` are delivered to `gdas.20210325/00/obs` bearing plausible-looking values for salt and temperature respectively, and seem to be assimilated. No quantitative analysis has been performed on these obs. # Companion PRs Not necessary for merging and passing ctests, but if new obs spaces get included the following is needed: NOAA-EMC/jcb-gdas#78 # Issues Mostly resolves #1132 # Automated CI tests to run in Global Workflow - [x] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !--> - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds separate salt and temperature obs space configuration files for Argo float observations.