Updates to the marine static-b yaml#30
Merged
Merged
Conversation
guillaumevernieres
requested review from
AndrewEichmann-NOAA,
CoryMartin-NOAA,
RussTreadon-NOAA and
danholdaway
RussTreadon-NOAA
approved these changes
Oct 2, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Change is correct. Approve.
guillaumevernieres
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Oct 3, 2024
I have yet to update the # for `jcb-gdas`. This will be done when [/NOAA-EMC/jcb-gdas/pull/30](NOAA-EMC/jcb-gdas#30) is merged. This branch requires changes in the `global-worflow` as well, see here: [https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes](https://github.com/guillaumevernieres/global-workflow/tree/feature/update_hashes) . We'll need to update the # and coordinate the merge ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusting yaml to reflect the switch to using
oops::utils::FieldSetHelpers::write/readFieldSet...I fail to see the point of this repo, what was wrong with keeping the yamls in the gdasapp?