Adds marine LETKF configuration template#11
Merged
Conversation
AndrewEichmann-NOAA
requested review from
DavidNew-NOAA and
guillaumevernieres
DavidNew-NOAA
previously requested changes
Jan 31, 2025
Contributor
DavidNew-NOAA
left a comment
DavidNew-NOAA
left a comment
There was a problem hiding this comment.
Otherwise looks good
1 task
guillaumevernieres
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Feb 20, 2025
# Description Adds components to have the marine letkf job use jcb yamls, also reorders ctests to reflect marine letkf's new dependecy on the bmat task # Companion PRs Companion to NOAA-EMC/jcb-algorithms#11 and future global-workflow PR This shouldn't break anything as it is redundant - non-jcb yamls can be removed after the global-workflow PR gets merged # Issues Partially addresses #1485 # Automated CI tests to run in Global Workflow - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
12 tasks
DavidNew-NOAA
pushed a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
# Description Adds components to have the marine letkf job use jcb yamls, also reorders ctests to reflect marine letkf's new dependecy on the bmat task # Companion PRs Companion to NOAA-EMC/jcb-algorithms#11 and future global-workflow PR This shouldn't break anything as it is redundant - non-jcb yamls can be removed after the global-workflow PR gets merged # Issues Partially addresses #1485 # Automated CI tests to run in Global Workflow - [x] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !--> --------- Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds marine LETKF configuration template. Tested with feature/letkf-j2 branch in GDASAapp and my fork of global-workflow.
Partially addresses NOAA-EMC/GDASApp#1485