Skip to content

wcoss2 cycled ecflow script with developer assigned path#719

Merged
KateFriedman-NOAA merged 3 commits into
NOAA-EMC:dev_v16from
lgannoaa:feature/dev-v16-dev-wcoss2
May 17, 2022
Merged

wcoss2 cycled ecflow script with developer assigned path#719
KateFriedman-NOAA merged 3 commits into
NOAA-EMC:dev_v16from
lgannoaa:feature/dev-v16-dev-wcoss2

Conversation

@lgannoaa
Copy link
Copy Markdown
Contributor

@lgannoaa lgannoaa commented Apr 8, 2022 •
edited
Loading

Description
A file in include directory to allow developer set development COM path.

closes #722

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes

lgannoaa added 2 commits April 8, 2022 17:39
@lgannoaa
This commit is the development seed
fa68fd0
@lgannoaa
This is the second part of ecflow PR. The developer enabled ecflow fi…
ce4a516 
…les - (modify the current dev_v16 with developer testing COM assignment)
@lgannoaa lgannoaa requested a review from aerorahul April 8, 2022 22:17
@lgannoaa lgannoaa self-assigned this Apr 8, 2022
@aerorahul
Copy link
Copy Markdown
Contributor

aerorahul commented Apr 8, 2022

It would be good to have NCO input on how to best handle the developer section as was discussed briefly in the meeting on Th. 4/7/2022.
@StevenEarle-NCO
Would you have time over the next week or so to look over a couple of these and provide insight on how to best handle developer information?

@lgannoaa lgannoaa changed the title Feature/dev v16 dev wcoss2 wcoss2 cycled ecflow script with developer assigned path Apr 9, 2022
@StevenEarle-NCO
Copy link
Copy Markdown

StevenEarle-NCO commented Apr 9, 2022

sure @aerorahul; calendar is up to date; schedule any time.

@lgannoaa lgannoaa marked this pull request as ready for review April 15, 2022 02:15
KateFriedman-NOAA
KateFriedman-NOAA reviewed Apr 19, 2022
View reviewed changes
Comment thread ecf/scripts/gdas/atmos/gempak/jgdas_atmos_gempak.ecf Outdated
@lgannoaa lgannoaa marked this pull request as draft April 21, 2022 14:55
@lgannoaa
Copy link
Copy Markdown
Contributor Author

lgannoaa commented Apr 25, 2022

NCO indicated the item on is completed, proceed to modify this PR with the updated action list.

@lgannoaa
Copy link
Copy Markdown
Contributor Author

lgannoaa commented Apr 28, 2022

The developer path assignment has been removed from the ecflow script level. It is now only in developer version of the include file.

@lgannoaa lgannoaa marked this pull request as ready for review April 28, 2022 18:59
@aerorahul
Copy link
Copy Markdown
Contributor

aerorahul commented May 6, 2022

@lgannoaa
The changes in this PR look good.
Please update the description to reflect the changes in this PR.
I think the description still mentions changing of some 25 ecf files, which are no longer necessary and are handled via the use of a user/developer specific envir-p1.h.

Thank you @StevenEarle-NCO for providing a developer friendly compath.py for WCOSS2. This greatly reduces/removes developer specific code blocks in the job-cards.

@lgannoaa
Copy link
Copy Markdown
Contributor Author

lgannoaa commented May 9, 2022

Requested modification is done.

aerorahul
aerorahul approved these changes May 9, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NCO maintains a operations specific envir-p1.h. This file in the repository is free to be used for developers providing development configurations.

@KateFriedman-NOAA KateFriedman-NOAA merged commit e7c6e16 into NOAA-EMC:dev_v16 May 17, 2022
@KateFriedman-NOAA KateFriedman-NOAA mentioned this pull request May 17, 2022
Closed
kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
@DeniseWorthen
fix type mis-matches in nst water property module (NOAA-EMC#719)
7eec3ce
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
@climbfuji
Update CCPP standard names for consistency (NOAA-EMC#719)
200315b 
This PR only updates the submodule pointer for fv3atm for the CCPP standard name updates.
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
@aerorahul
update templates for diag_table to be consistent with model_configure (…
77eaba8 
…NOAA-EMC#781)

* update templates for diag_table to be consistent with model_configure
* remove edit_diag_table function. point to @climbfuji branch of FV3atm
* FV3 is updated with land mask bug fix (CCPP issue NOAA-EMC#719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

+2 more reviewers

@StevenEarle-NCO StevenEarle-NCO StevenEarle-NCO left review comments

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@KateFriedman-NOAA KateFriedman-NOAA

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lgannoaa @aerorahul @StevenEarle-NCO @WalterKolczynski-NOAA @KateFriedman-NOAA