(develop) Add wavegempak dependency to gfs_arch_tars#4954
Merged
Conversation
When do_wave and do_gempak are both enabled, the archive tarball job (gfs_arch_tars) now depends on the wavegempak metatask completing. This prevents the archive from starting while wave GEMPAK jobs are still running and producing output files. Fixes: gfs_arch_tars should have a dependency on wave awips jobs
Copilot
AI
changed the title
[WIP] Fix gfs_arch_tars to have a dependency on wave awips jobs
Add wavegempak dependency to gfs_arch_tars
Jun 1, 2026
DavidHuber-NOAA
added
the
CI-Wcoss2-Running
DavidHuber-NOAA
changed the title
DavidHuber-NOAA
added
CI-Wcoss2-Passed
Contributor
|
All tests passed on WCOSS2: |
Contributor
|
Opening for review. |
JessicaMeixner-NOAA
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a missing dependency for
gfs_wavegempakjobs.gfs_arch_tarscould start beforegfs_wavegempakfinished when both wave and GEMPAK products were enabled, causing actively-written log/output files to be archived mid-write.waveawipsbullsandwaveawipsgriddedwere already guarded by thedo_awipsblock, butwavegempakhad no corresponding dependency in_arch_tars_deps(). Added it:Refs #4926
Type of change
Change characteristics
How has this been tested?
_arch_tars_deps()against all wave downstream task activation conditions ingfs_forecast_only.pyandgfs_cycled.pyChecklist