[develop] Add informative error messages to all err_exit calls#4793
Conversation
|
Launching CI on Ursa to test the new HPC account. CC: @TerrenceMcGuinness-NOAA. |
…a/global-workflow into feature/err_exit_messages
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
A couple of suggestions for the jedi letkf ones
Co-authored-by: Travis Elless <113720457+TravisElless-NOAA@users.noreply.github.com>
|
@DavidHuber-NOAA Testing of HPC_ACCOUNT propagating to CI pipeline experiments failed: Falling back on hardcoding if in role account for now (stopping test and restarting it): |
|
Erased the RUNDIR on disk and re-ran C48_ATM case from GitLab and HPC_ACCOUNT propagates from hard coded And they do not get suck in PRIORITY and are running: |
ChristopherHill-NOAA
left a comment
There was a problem hiding this comment.
Suggesting modifications to several of the proposed downstream product err_exit messages. Correction of spelling error within JGDAS_ATMOS_GEMPAK included.
|
The updates to the bufr sounding job JGFS_ATMOS_POSTSND and the ush script look good to me. |
EdwardSafford-NOAA
left a comment
There was a problem hiding this comment.
DA monitor changes look good.
Co-authored-by: Christopher Hill <102273578+ChristopherHill-NOAA@users.noreply.github.com>
|
Thank you for the suggestions @ChristopherHill-NOAA. I've incorporated them. |
|
Launching tests on WCOSS2. |
|
All tests passed on WCOSS2 except I have committed that change and am marking WCOSS2 CI as passed. |
Description
This adds informative error messages to all
err_exitcalls. This was flagged as an issue for GCAFS and is being addressed across the board. It also removeserr_exitcalls fromush/scripts in favor ofexitcalls.Refs #4722
Resolves #4811
Type of change
Change characteristics
How has this been tested?
Running CI on Ursa
Checklist