De-globify ocean analysis yamls#4159
Conversation
removes the *yaml glob used in archiving and replace with explicit filesnames
AndrewEichmann-NOAA
requested review from
JessicaMeixner-NOAA and
guillaumevernieres
|
Thanks for making this PR @AndrewEichmann-NOAA ! |
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_diagb.yaml' | ||
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}gridgen.yaml' | ||
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_vtscales.yaml' | ||
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_ensweights.yaml' |
There was a problem hiding this comment.
Does this config only exist for certain options?
See: vi /6/ira-sti/world-shared/Jessica.Meixner/togwdevrt17/hpss01/COMROOT/C48mx500_3DVarAOWCDA_hpss01/logs/2021032500/gdas_arch_tar_gdasocean_analysis.log.0 where we get an error that this file does not exist.
In the conf file I have:
backup_tarballs.yaml gdas.t00z.soca_chgres.yaml gdas.t00z.soca_vtscales.yaml ufs.ice_in ufs.ww3_shel.nml
fields_metadata.yaml gdas.t00z.soca_diagb.yaml MOM_parameter_doc.all ufs.input.nml var.yaml
gdas.t00z.bmat_fields_metadata.yaml gdas.t00z.soca_parameters_diffusion_hz.yaml obsop_name_map.yaml ufs.model_configure
gdas.t00z.gridgen.yaml gdas.t00z.soca_parameters_diffusion_vt.yaml soca_incpostproc.yaml ufs.MOM_input
gdas.t00z.obsop_name_map.yaml gdas.t00z.soca_setcorscales.yaml ufs.diag_table ufs.ufs.configure
There was a problem hiding this comment.
@JessicaMeixner-NOAA Which file doesn't exist?
There was a problem hiding this comment.
soca_ensweights.yam
There was a problem hiding this comment.
That does sound hybrid-specifc. @guillaumevernieres ?
There was a problem hiding this comment.
Looks like it - that and soca_ensb - this is what gets saved to com:
There was a problem hiding this comment.
yes, soca_ensweights.yaml is only for the hybrid.
|
Testing help up by /scratch4 quota |
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_vtscales.yaml' | ||
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}bmat_fields_metadata.yaml' | ||
| - '{{ COMIN_CONF | relpath(ROTDIR) }}/var.yaml' | ||
| # soca_parameters_diffusion_vt, and soca_parameters_diffusion_hz when present |
There was a problem hiding this comment.
Since it says when present should they be in the optional section?
There was a problem hiding this comment.
@guillaumevernieres Do we want to allow any others to be optional?
This combines updates from PR #4159 which Fixes #4158 Removes archiving of log files that have "tar" in the name so all tar-archiving log files will be skipped and avoid an error that log file is still being written. Reduces wave archiving #4150 And updates from @CatherineThomas-NOAA based on discussions with the marine-DA team to reduce archiving. It also updated ufs-utils and ufs-weather-model to the top of develop when I started testing. Fixes #4158 Fixes #4155 Fixes #4150
|
@JessicaMeixner-NOAA was this PR wrapped into #4184? |
Removed several background error files from the YAML configuration - reverts part of previous merged from develop
|
At this point the only changes are to the |
|
Closing for now. This can be revisited if needed at a later time if needed. |
yes. |
5 participants
Description
Removes the *yaml glob used in archiving of ocean analysis files and replaces them with explicit filenames, to avoid sweeping in unrelated yaml files.
Resolves #4158
Type of change
Change characteristics
How has this been tested?
Not yet testedTested with
C96C48mx500_S2SW_cyc_gfsandC48mx500_3DVarAOWCDAon Ursa, with archived tarballs as follows:Checklist