Skip to content

Replace cp with cpfs/cpreq for atomic copies to COM directories #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHuber-NOAA merged 8 commits into from
Oct 27, 2025
Merged

Replace cp with cpfs/cpreq for atomic copies to COM directories #4130

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e3a2e62
Initial plan
Copilot Oct 6, 2025
9141f12
Replace cp with cpfs/cpreq for atomic copies to COM directories
Copilot Oct 6, 2025
2137a91
Merge branch 'develop' into copilot/fix-e87036ed-45fd-4baa-9f7e-6bceb…
DavidHuber-NOAA Oct 8, 2025
cac08db
Merge branch 'develop' into copilot/fix-e87036ed-45fd-4baa-9f7e-6bceb…
DavidHuber-NOAA Oct 8, 2025
96ec98a
Apply suggestions from code review
DavidHuber-NOAA Oct 20, 2025
69ebd41
Replace all other instances of cp with cpreq/fs
DavidHuber-NOAA Oct 22, 2025
7917ae5
Merge remote-tracking branch 'origin/develop' into copilot/fix-e87036…
DavidHuber-NOAA Oct 22, 2025
e95f278
Correct cpfs/cpreq usage
DavidHuber-NOAA Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ush/syndat_qctropcy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ positional parameter 1"
# (Note: Only do so if files don't already exist)

if [[ ! -s "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}" ]]; then
cp "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
cpfs "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
fi
if [[ ! -s "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}" ]]; then
cp "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"
cpfs "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
fi

exit
Expand Down Expand Up @@ -277,10 +277,10 @@ if [ "$errqct" -gt '0' ];then
# (Note: Only do so if files don't already exist)

if [[ ! -s "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}" ]]; then
cp "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
cpfs "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
fi
if [[ ! -s ${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark} ]]; then
cp "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"
cpfs "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
fi

exit
Expand Down Expand Up @@ -354,14 +354,14 @@ fi


# This is the file that connects to the later RELOCATE and/or PREP scripts
cp current "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
cpfs current "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"

# Create the DBNet alert
if [[ "${SENDDBN}" == "YES" ]]; then
"${DBNROOT}/bin/dbn_alert" "MODEL" "GDAS_TCVITALS" "${job}" "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}"
fi

# Write JTWC/FNOC Tcvitals to /com path since not saved anywhere else
cp fnoc "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"
cpfs fnoc "${COMOUT_OBS}/${RUN}.${cycle}.jtwc-fnoc.tcvitals.${tmmark}"

exit
10 changes: 5 additions & 5 deletions ush/tropcy_relocate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ to center relocation date/time;"
if [ $fhr = "0" ]; then
"${USHgfs}/getges.sh" -e "${envir_getges}" -n "${network_getges}" -v "${run_date}" \
-t "${stype}" > "${COMOUT_OBS}/${RUN}.${cycle}.sgesprep_pre-relocate_pathname.${tmmark}"
cp "${COMOUT_OBS}/${RUN}.${cycle}.sgesprep_pre-relocate_pathname.${tmmark}" \
cpfs "${COMOUT_OBS}/${RUN}.${cycle}.sgesprep_pre-relocate_pathname.${tmmark}" \
"${COMOUT_OBS}/${RUN}.${cycle}.sgesprep_pathname.${tmmark}"
fi
set +x
Expand Down Expand Up @@ -391,7 +391,7 @@ done
if [ -f ${tstsp}syndata.tcvitals.$tmmark ]; then
cp ${tstsp}syndata.tcvitals.$tmmark tcvitals.now
else
cp "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}" "tcvitals.now"
cpreq "${COMOUT_OBS}/${RUN}.${cycle}.syndata.tcvitals.${tmmark}" "tcvitals.now"
fi


Expand Down Expand Up @@ -430,7 +430,7 @@ RELOCATION PROCESSING"

echo "NO RECORDS to process" > "${COMOUT_OBS}/${RUN}.${cycle}.tropcy_relocation_status.${tmmark}"
if [[ ! -s "${COMOUT_OBS}/${RUN}.${cycle}.tcvitals.relocate.${tmmark}" ]]; then
cp "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.tcvitals.relocate.${tmmark}"
cpfs "/dev/null" "${COMOUT_OBS}/${RUN}.${cycle}.tcvitals.relocate.${tmmark}"
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
fi
else

Expand Down Expand Up @@ -570,8 +570,8 @@ else
rm -f RELOCATE_GES cmd


cp "rel_inform1" "${COMOUT_OBS}/${RUN}.${cycle}.inform.relocate.${tmmark}"
cp "tcvitals" "${COMOUT_OBS}/${RUN}.${cycle}.tcvitals.relocate.${tmmark}"
cpfs "rel_inform1" "${COMOUT_OBS}/${RUN}.${cycle}.inform.relocate.${tmmark}"
cpfs "tcvitals" "${COMOUT_OBS}/${RUN}.${cycle}.tcvitals.relocate.${tmmark}"
if [[ "${SENDDBN}" == "YES" ]]; then
if test "$RUN" = "gdas1"
then
Expand Down
2 changes: 1 addition & 1 deletion ush/wave_prnc_ice.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ EOF
fi

echo " Saving ice.ww3 as ${COMOUT_WAVE_PREP}/${icefile}"
cp ice.ww3 "${COMOUT_WAVE_PREP}/${icefile}"
cpfs ice.ww3 "${COMOUT_WAVE_PREP}/${icefile}"
rm -f ice.ww3

# --------------------------------------------------------------------------- #
Expand Down