Skip to content

Consolidate load_*_modules scripts into a generic load_modules.sh script #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHuber-NOAA merged 16 commits into from
Oct 8, 2025
Merged

Consolidate load_*_modules scripts into a generic load_modules.sh script #4126

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
36bb3ec
Initial plan
Copilot Oct 6, 2025
cae2802
Create consolidated load_modules.sh script and update all job files
Copilot Oct 6, 2025
d9735ac
Fix gaeac5 handling in load_modules.sh to match original behavior
Copilot Oct 6, 2025
1c6c1a2
Convert old module loading scripts to wrapper scripts for backwards c…
Copilot Oct 6, 2025
d98c09b
Fix commented reference in wavepostbndpntbll.sh
Copilot Oct 6, 2025
8c58a82
Simplify module loading logic and remove deprecated symlink creation
Copilot Oct 6, 2025
91202fe
Ignore spoc links
DavidHuber-NOAA Oct 7, 2025
995848b
Update inline documentation for load_modules.sh
DavidHuber-NOAA Oct 7, 2025
e9af8fe
Update codeowners file
DavidHuber-NOAA Oct 7, 2025
cccd780
No need to ignore fv3gfs script
DavidHuber-NOAA Oct 7, 2025
d9417d1
Remove now-unused load_*_modules scripts
DavidHuber-NOAA Oct 7, 2025
89b1280
Merge develop
DavidHuber-NOAA Oct 7, 2025
92d661f
Merge remote-tracking branch 'origin/develop' into copilot/fix-c81836…
DavidHuber-NOAA Oct 7, 2025
cf3a427
Clean up error messages.
DavidHuber-NOAA Oct 8, 2025
73fddb0
Update .github/CODEOWNERS
DavidHuber-NOAA Oct 8, 2025
7f78d08
Merge branch 'develop' into copilot/fix-c818364e-fc40-4058-a3f5-65822…
DavidHuber-NOAA Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,7 @@ ush/interp_atmos_master.sh @aerorahul @WenMeng-NOAA
ush/interp_atmos_sflux.sh @aerorahul @WenMeng-NOAA
ush/jjob_header.sh
ush/link_crtm_fix.sh
ush/load_fv3gfs_modules.sh @aerorahul
ush/load_gw_run_modules.sh @aerorahul @DavidHuber-NOAA
ush/load_gw_gsi_modules.sh @aerorahul @DavidHuber-NOAA @RussTreadon-NOAA
ush/load_ufsda_modules.sh @aerorahul @CoryMartin-NOAA
ush/load_ufswm_modules.sh @aerorahul @JessicaMeixner-NOAA
ush/load_modules.sh @aerorahul @DavidHuber-NOAA @RussTreadon-NOAA @JessicaMeixner-NOAA
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
ush/merge_fv3_aerosol_tile.py
ush/minmon_xtrct_*.pl @EdwardSafford-NOAA
ush/module-setup.sh @aerorahul
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ parm/gdas/ioda
parm/gdas/marine
parm/gdas/snow
parm/gdas/soca
parm/gdas/spoc
parm/gdas/stat
parm/gdas/jcb-gdas
parm/gdas/jcb-algorithms
Expand Down Expand Up @@ -177,7 +178,7 @@ ush/python/ufsda
ush/python/soca
ush/python/gen_bufr2ioda_json.py
ush/python/gen_bufr2ioda_yaml.py
dev/ush/load_fv3gfs_modules.sh
ush/spoc
# ush log file
ush/fetch-fix-data.log

Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/aeroanlfinal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/aeroanlgenb.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/aeroanlinit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/aeroanlvar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/aerosol_init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/anal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/analcalc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source GSI workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/analcalc_fv3jedi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"

Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/analdiag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/anlstat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
err=$?
if [[ ${err} -ne 0 ]]; then
echo "FATAL ERROR Failed to load UFSDA modules!"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/arch_tars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/arch_vrfy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmanlfinal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmanlfv3inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmanlinit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmanlvar.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlfinal.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlfv3inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlinit.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlletkf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlobs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmensanlsol.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmos_ensstat.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -x
###############################################################

# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if ((status != 0)); then exit "${status}"; fi

Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/atmos_products.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -x
###############################################################

# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if ((status != 0)); then exit "${status}"; fi

Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/awips.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#! /usr/bin/env bash

set -x
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/awips_20km_1p0deg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/cleanup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/earc_tars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/earc_vrfy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/ecen.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/ecen_fv3jedi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"

Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/echgres.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/ediag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/eobs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/epos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source GSI workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/esfc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source GSI workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/esnowanl.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

###############################################################
# Source UFSDA workflow modules
source "${HOMEgfs}/dev/ush/load_ufsda_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" ufsda
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/eupd.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -x

###############################################################
# Source FV3GFS workflow modules
source "${HOMEgfs}/dev/ush/load_gw_gsi_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" gsi
status=$?
if [[ ${status} -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/extractvars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -x
###############################################################
echo
echo "=============== START TO SOURCE FV3GFS WORKFLOW MODULES ==============="
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if [[ "${status}" -ne 0 ]]; then
exit "${status}"
Expand Down
2 changes: 1 addition & 1 deletion dev/jobs/fbwind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -x

###############################################################
source "${HOMEgfs}/dev/ush/load_fv3gfs_modules.sh"
source "${HOMEgfs}/dev/ush/load_modules.sh" run
status=$?
if ((status != 0)); then exit "${status}"; fi

Expand Down
Loading