Skip to content

Only run wave bnd pnt for gfs#4112

Merged
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:wavecleanup
Sep 30, 2025
Merged

Only run wave bnd pnt for gfs#4112
DavidHuber-NOAA merged 3 commits into
NOAA-EMC:developfrom
JessicaMeixner-NOAA:wavecleanup

Conversation

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor

Description

This PR updates gfs config so that the boundary point jobs are only run for GFS, not gdas.

Fixes #3899

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

I ran C96C48mx500_S2SW_cyc_gfs on WCOSS2. Test is here: /lfs/h2/emc/couple/noscrub/jessica.meixner/wavegwissues/RUNTESTS Note at the time of writing, the test was not complete, but it was past the main parts. The XML also shows that boundary points are only in the gfs jobs, not gdas now.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor Author

@DavidHuber-NOAA - If you think additional tests are needed, I'm happy to run them, just let me know what tests (or full set) and what machines.

@JessicaMeixner-NOAA
Copy link
Copy Markdown
Contributor Author

Test completed successfully:

******** /lfs/h2/emc/couple/noscrub/jessica.meixner/wavegwissues/RUNTESTS/EXPDIR/C96C48mx500_S2SW_cyc_gfs_bndp01 ********
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Sep 29 2025 17:25:17    Sep 29 2025 17:45:54
202112201800        Done    Sep 29 2025 17:25:17    Sep 29 2025 20:25:42
202112210000        Done    Sep 29 2025 17:25:17    Sep 29 2025 21:10:56
202112211800        Done    Sep 29 2025 17:50:40    Sep 29 2025 21:10:57

Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DavidHuber-NOAA
Copy link
Copy Markdown
Contributor

I confirmed that the generated C96C48mx500_S2SW_cyc_gfs_bndp01 test XML only generated bndpnt jobs for the gfs cycles. Merging.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 98ddb76 into NOAA-EMC:develop Sep 30, 2025
5 checks passed
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Oct 8, 2025
…into feature/adjust_tasks_per_node_layout

* 'develop' of github.com:NOAA-EPIC/global-workflow-cloud:
  Update CODEOWNERS for new oceanice_products assignments (NOAA-EMC#4134)
  Improve GW forecast timing of high-resolution runs with findings from containerized GW (NOAA-EMC#4123)
  Update CODEOWNERS to change job assignments (NOAA-EMC#4128)
  Update j-jobs to be bash linter compliant (NOAA-EMC#4124)
  Update the marine analysis archiving (NOAA-EMC#4082)
  Port tracker/genesis tasks to cloud; load wgrib2; add noaacloud to load_gw_gsi_modules (NOAA-EMC#4111)
  Only run wave bnd pnt for gfs (NOAA-EMC#4112)
weihuang-jedi added a commit to NOAA-EPIC/global-workflow-cloud that referenced this pull request Nov 5, 2025
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2

* 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud:
  only double quota varaibles
  only double quota varaibles
  need run_mpmd.sh changes
  remove  config.resources.URSA from sfs
  recover ursa.yaml
  testing on ursa
  working on aws
  remove unused dir
  Update the marine analysis archiving (NOAA-EMC#4082)
  Port tracker/genesis tasks to cloud; load wgrib2; add noaacloud to load_gw_gsi_modules (NOAA-EMC#4111)
  Only run wave bnd pnt for gfs (NOAA-EMC#4112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gdas wave should not be running boundary point jobs.

2 participants