Consolidate JEDI-based atmospheric analysis task configuration YAMLs and create new Analysis class#4080
Merged
Merged
Conversation
DavidNew-NOAA
changed the title
DavidNew-NOAA
changed the title
Contributor
|
g-w CI testing for this PR has begun on WCOSS2 (Cactus). Results will be posted when all WCOSS2 g-w CI tests complete. |
Contributor
Author
|
Hera CI passes |
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Oct 8, 2025
… master files (#1896) # Description This PR does a number of things for atmopshere, aerosol, and snow tasks.: 1. Configuration J2-YAMLs for JEDI configuration and staging/saving files are consolidated into a single J2-YAML file for each task. 2. Unified/centralized observation lists are created and are inserted via a `{% include OBS_LIST_YAML %}` statement in the jcb-prototype J2-YAMLs for atmospheric analysis tasks. For the atmosphere, there are three obs lists, one for GW-CI testing, one for atm-jjob tests, and a default one. 3. The (currently defunct) JEDI-testing blocks (containing reference files and test tolerances) that go into the jcb-prototype J2-YAMLs are put into their own templates. Along with the unified obs lists, this allows there to be a single jcb-prototype J2-YAMLs for each JEDI application. # Companion PRs NOAA-EMC/global-workflow#4080 # Issues Refs [#4321](NOAA-EMC/global-workflow#4079) # Automated CI tests to run in Global Workflow N/A (testing done is GW companion PR) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CoryMartin-NOAA
previously approved these changes
Oct 8, 2025
20 tasks
Contributor
|
WCOSS2 g-w CI Install Only C96_atm3DVar_extended remains running. This CI test runs GSI-based DA. The GSI-based DA jobs have completed. The gfs forecasts and downstream jobs are running or pending. This test does not exercise JEDI-based DA, the focus of this PR. All jobs in all other CI cases have already successfully run to completion. |
RussTreadon-NOAA
previously approved these changes
Oct 8, 2025
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
WCOSS2 (Cactus) g-w CI passed for all DA jobs. Only forecast and downstream jobs remain running or pending for C96_atm3DVar_extended.
The sorc/gdas.cd has in this PR points at the current head of GDASApp develop. We want to retain sorc/gdas.cd @ 6b00f28 in this PR.
Approve.
DavidNew-NOAA
dismissed stale reviews from RussTreadon-NOAA and CoryMartin-NOAA
via
5f1d7e3
DavidNew-NOAA
added
the
CI-Wcoss2-Passed (CM)
Contributor
Author
|
@aerorahul @DavidHuber-NOAA Manual CI on Hera and Wcoss has passed. Are there any other obstacles to merging this branch? |
Contributor
|
WCOSS2 g-w CI Document for the sake of completeness that all job in g-w CI case C96_atm3DVar_extended successfully ran to completion on Cactus. |
aerorahul
approved these changes
Oct 9, 2025
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
lgtm.
Thanks @DavidNew-NOAA for this work!
DavidHuber-NOAA
approved these changes
Oct 9, 2025
Contributor
|
I am getting an error from GitHub when attempting to merge this PR: |
7 tasks
This was referenced Nov 3, 2025
weihuang-jedi
added a commit
to NOAA-EPIC/global-workflow-cloud
that referenced
this pull request
Nov 5, 2025
…NOAA-EPIC/global-workflow-cloud into feature/use_container_spack-stack-1.9.2 * 'feature/use_container_spack-stack-1.9.2' of github.com:NOAA-EPIC/global-workflow-cloud: remove env/*.container testing on AWS no need to save to repo, as it is a link add PYCMD merge develop change in Consolidate JEDI-based atmospheric analysis task configuration YAMLs and create new Analysis class (NOAA-EMC#4080) Ctest case updates (NOAA-EMC#4118) using PYCMD fix archive script Consolidate load_*_modules scripts into a generic load_modules.sh script (NOAA-EMC#4126) Updates for Gaea C6 following OS upgrade (NOAA-EMC#4110) combine few scripts to decrease numbers reverse to GW repo code, and new way to handle jobs scripts Correct parametric and ensemble background error statistics filenames in marine DA (NOAA-EMC#4120)
DavidNew-NOAA
added a commit
to NOAA-EMC/GDASApp
that referenced
this pull request
Jan 16, 2026
… master files (#1896) # Description This PR does a number of things for atmopshere, aerosol, and snow tasks.: 1. Configuration J2-YAMLs for JEDI configuration and staging/saving files are consolidated into a single J2-YAML file for each task. 2. Unified/centralized observation lists are created and are inserted via a `{% include OBS_LIST_YAML %}` statement in the jcb-prototype J2-YAMLs for atmospheric analysis tasks. For the atmosphere, there are three obs lists, one for GW-CI testing, one for atm-jjob tests, and a default one. 3. The (currently defunct) JEDI-testing blocks (containing reference files and test tolerances) that go into the jcb-prototype J2-YAMLs are put into their own templates. Along with the unified obs lists, this allows there to be a single jcb-prototype J2-YAMLs for each JEDI application. # Companion PRs NOAA-EMC/global-workflow#4080 # Issues Refs [#4321](NOAA-EMC/global-workflow#4079) # Automated CI tests to run in Global Workflow N/A (testing done is GW companion PR) --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR does two things:
Analysischild class ofTaskis created for JEDI-based tasks and they are inherited from those tasks rather than fromTask.Analysisdefines several variables and methods used across a variety tasks (GPREFIX,APREFIX, etc).Resolves #4079
Resolves #4023
Type of change
Change characteristics
How has this been tested?
Build, clone, and CI testing on Hera
Checklist