Reorganize parm/gdas#4011
Conversation
|
@DavidHuber-NOAA I added CI-Hera-Running label to indicate that I'm running CI on Hera manually |
|
Hera CI passes with hash |
|
WCOSS2 g-w CI Install All g-w CI cases configured to run on WCOSS2 successfully completed. The only exception is C96_atm3DVar_extended which is still running. Thus far, no errors have occurred in C96_atm3DVar_extended. The status of the WCOSS2 C96_atm3DVar_extended will be reported once all jobs complete. |
|
WCOSS2 g-w CI C96_atm3DVar_extended finished. All jobs in all cycles successfully ran to completion. |
|
@DavidHuber-NOAA : The CI-Wcoss2-Running label can be changed to CI-Wcoss2-Passed. I would do so but I don't know g-w CM policy. Hence this comment. |
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
g-w CI Passed on Gaea C6, Hera and WCOSS2 (Cactus).
Approve.
|
All tests passed. Merging. |
|
Thanks @RussTreadon-NOAA snd @DavidHuber-NOAA for testing |
This aims to finally organize the `parm/gdas` directory, which currently has files distributed between Global Workflow and GDASApp, since many of its directories are symlinked from the `parm` directory of GDASApp, and move all files into GDASApp. The files will be renamed in the GDASApp to give them a unified naming convention. This then gives the environment variables that point to these files a unified naming convention that corresponds directly to that file name. This will make it easier for developers to find the underlying file that these variables point to, a common issue when working with JEDI tasks.
# Description This PR does a couple things. 1. It moves every file that lives in Global Workflow `parm/gdas` into GDASApp `parm` and into the appropriate subdirectory (`parm/atm`, `parm/aero`, etc) 2. All `parm` files that feed into the wxflow FileHandler or configure the GW `Jedi` class (most of the files in `parm`) are given a unified naming convention of `(domain)_(task)_(stage/save)_(thing being staged or saved).yaml.j2` or `(domain)_(task)_jedi_config.yaml.j2` respectively. For example, the file that stages atmospheric deterministic backgrounds is called `atm_det_stage_bkg.yaml.j2`. 3. `parm/soca` becomes `parm/marine` for consistency. 4. Anything that doesn't seem to be used in `parm` is moved to `parm/obsolete`. # Companion PRs NOAA-EMC/global-workflow#4011 # Issues Refs NOAA-EMC/global-workflow#3973 --------- Co-authored-by: root <root> Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com> Co-authored-by: Cory Martin <cory.r.martin@noaa.gov> Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com> Co-authored-by: RussTreadon-NOAA <26926959+RussTreadon-NOAA@users.noreply.github.com> Co-authored-by: danholdaway <danholdaway@users.noreply.github.com> Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com> Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov> Co-authored-by: RussTreadon-NOAA <russ.treadon@noaa.gov> Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov> Co-authored-by: AntonMFernando-NOAA <167725623+AntonMFernando-NOAA@users.noreply.github.com> Co-authored-by: Anil Kumar <108816337+AnilKumar-NOAA@users.noreply.github.com> Co-authored-by: TerrenceMcGuinness-NOAA <terrence.mcguinness@cox.net> Co-authored-by: Andrew.Tangborn <Andrew.Tangborn@noaa.gov> Co-authored-by: Jiarui Dong <Jiarui.Dong@noaa.gov> Co-authored-by: Cory Martin <Cory.R.Martin@gaea68.ncrc.gov> Co-authored-by: Travis Elless <113720457+TravisElless-NOAA@users.noreply.github.com> Co-authored-by: Anna Shlyaeva <anna.v.shlyaeva@noaa.gov> Co-authored-by: Kate Friedman <kate.friedman@noaa.gov> Co-authored-by: Cory Martin <Cory.R.Martin@gaea67.ncrc.gov> Co-authored-by: Cory Martin <Cory.R.Martin@gaea66.ncrc.gov> Co-authored-by: Kevin Dougherty <kevin.dougherty@noaa.gov> Co-authored-by: Kevin Dougherty <69815622+kevindougherty-noaa@users.noreply.github.com> Co-authored-by: Anna Shlyaeva <annash@ucar.edu> Co-authored-by: yuanxue2870 <136842224+yuanxue2870@users.noreply.github.com> Co-authored-by: Yaping Wang <49168260+ypwang19@users.noreply.github.com>
Description
This PR aims to finally organize the
parm/gdasdirectory, which currently has files distributed between Global Workflow and GDASApp, since many of its directories are symlinked from theparmdirectory of GDASApp, and move all files into GDASApp.The files will be renamed in GDASApp companion PR *** to give them a unified naming convention. This PR then gives the environment variables that point to these files a unified naming convention that corresponds directly to that file name. This will make it easier for developers to find the underlying file that these variables point to, a common issue when working with JEDI tasks.
Type of change
Change characteristics
How has this been tested?
Clone, build, and full CI suite on Hera
Checklist