Update coupled with develop#364
Closed
WalterKolczynski-NOAA wants to merge 151 commits into
Closed
Conversation
…heckout/build/linking for UPP tag that supports hpc-stack, remove post patch in HERA.env
…r hpc-stack, plus updates for building enkf_chgres_recenter, gfs_bufr, and tocsbufr with hpc-stack
* origin/develop: Issue NOAA-EMC#179 and issue NOAA-EMC#243 - update Fit2Obs to newm.1.2 tag and correct COMROOT path for Hera HOTFIX: Issue NOAA-EMC#241 - update EMC_verif-global tag to remove use of /tmp space
…tes for fbwndgfs and grib_util builds
Update free-forecast mode to interface with UFS_UTILS gdas_init utility scripts. Update getic job to use gdas_init get scripts to pull ICs off HPSS for GFS versions 13 and later. Rename fv3ic job to "init" and update it to interface with gdas_init run scripts to run chgres_cube and produce GFSv16 ICs. Update job dependencies to detect need to run chgres jobs and hold forecast jobs until ICs are generated or present. Further updates coming for this task. Tested on WCOSS-Dell, need to test elsewhere still. Will disable getic job on Orion. Refs: #1, NOAA-EMC#178
The free-forecast mode fcst job data dependency file path was missing the component "atmos" subfolder. Added and tested in experiment on Hera. Refs: NOAA-EMC#178
- Remove unneeded ignores from .gitignore - Update Externals.cfg and checkout.sh for component stack versions - Update link_fv3gfs.sh for changed component links - Further Hera module updates for hpc-stack Refs: NOAA-EMC#164
- move COMPONENT setting from getic to init job - cleanup how getic job sets tarball paths and pulls pgbanl files - move second step of pgbanl pull to init job for consistency - add MODE variable to config.base and its definition to setup scripts - add MODE setting to config.base if-block that adjusts IAU variables - add missing COMPONENT subfolder to data dependencies for getic and init jobs in setup_workflow_fcstonly.py - remove unneeded commented out wavestat job from setup_workflow_fcstonly.py Refs: NOAA-EMC#178
* upstream/develop: Update Fit2Obs tag to newm.1.3 for bugfix Update Fit2Obs tag to newm.1.3 for bugfix Update EMC_verif-global tag for Hera bug Pull in nwpara/gfsv16.0.6 updates for parse-storm-type.pl HOTFIX: Update EMC_verif-global tag for Hera bug Issue #1 and issue NOAA-EMC#238 - update Externals.cfg to match checkout.sh updates for v16.0.6 move errchk definition from script to job for wave prdgen and gempak adding definition of errchk which was undefined in these scripts Issue NOAA-EMC#179 and issue NOAA-EMC#243 - update Fit2Obs to newm.1.2 tag and correct COMROOT path for Hera HOTFIX: Issue NOAA-EMC#241 - update EMC_verif-global tag to remove use of /tmp space Issue #1 and issue NOAA-EMC#233 - update GLDAS tag to gldas_gfsv16_release.v1.13.0 Issue #1 and issue NOAA-EMC#241 - update EMC_verif-global tag Issue #1 and issue NOAA-EMC#238 - remove ak_10m grid from config.wave and update checkout.sh tags for ufs-weather-model and EMC_gfs_wafs Issue NOAA-EMC#179 - update to config.vrfy for Fit2Obs tag which supports Orion Issue #1 and issue NOAA-EMC#226 - update UPP tag to upp_gfsv16_release.v1.1.3 in Externals.cfg Issue #1 and issue NOAA-EMC#226 - update UPP tag to upp_gfsv16_release.v1.1.3 Issue NOAA-EMC#233 - remove unnecessary extra space in tag line for gldas Issue NOAA-EMC#233 - update GLDAS tag to gldas_gfsv16_release.v1.13.0 Issue #1 and issue NOAA-EMC#226 - update exgfs_atmos_grib2_special_npoess.sh for dbn_alert issue NOAA-EMC#227 reducing output bufr files to 64 levels per NCO request issue NOAA-EMC#227 reducing output bufr files to 64 levels per NCO request Issue #1: update ecflow to be consistent with NCO's gfs.v16.0.4 and update checkout to bring in new UPP tag (see issue NOAA-EMC#226) Upaded ush script scale_dec.sh Updated scripts gfs_v16.0 Refs: NOAA-EMC#178
- update getic and init jobs to use DATA folder and ROTDIR - move pgb copy back to getic job since it now dumps into ROTDIR - update setup_workflow_fcstonly.py to turn off getic on Orion and adjust dependencies for init for input files from supported versions Refs: NOAA-EMC#178
- add needed exports in getic.sh - add check to init for whether it needs to run - add check to init for copying pgbanl files when getic doesn't run - remove atmos subfolder from init dependencies for older versions Refs: NOAA-EMC#178
- add COMPONENT setting back into getic.sh - add gfsinit as dependency to gfswaveprep since UFS_UTILS gdas_init scripts remove the atmos folder Refs: NOAA-EMC#178
- change config.fv3 to use 4 threads for C96 (too few nodes with 1 thread) - update GFSv16 version if-block date in getic and init scripts to use updated/tentative implementation date; update when finalized Refs: NOAA-EMC#178
- add variables: MODE to dilineate free-forecast and cycled modes; RETRO variable to toggle between v16 ops and retro inputs - update arch step to archive INPUT files instead of RESTART files when in free (free-forecast) mode; other small fixes to arch step - set NSST to spinup before availability date - added support for running off v16 retrospective inputs - fix missing bufrsnd job in free-forecast mode - update resource settings for C48 and C96; further refinement coming Refs: NOAA-EMC#178
* origin/develop: remove flags that were not present in Makefiles update jasper to 2.x.25. remove compiler flag in fv3nc2nemsio Update EMC_verif-global tag to verif_global_v1.13.4 another use of _d where an _4 is needed Adjust how target is set for build_workflow_utils Add workflow_utils to build_all and link scripts copy/paste error from enkf_chgres_recenter.fd to enkf_chgres_recenter_nc.fd. When going from nemsio to netcdf, the linking of ip, sp and w3nco changed from _d to _4. update .gitignore to exclude build and install directories as well as compiled files. bugfix in build_workflow_utils.sh hack. nceplibs-ncio now creates the module ncio and not fv3gfs_ncio. add cmake build capability for workflow utilities Update Fit2Obs tag to newm.1.3 for bugfix Update Fit2Obs tag to newm.1.3 for bugfix Update EMC_verif-global tag for Hera bug Pull in nwpara/gfsv16.0.6 updates for parse-storm-type.pl HOTFIX: Update EMC_verif-global tag for Hera bug Issue #1 and issue NOAA-EMC#238 - update Externals.cfg to match checkout.sh updates for v16.0.6 move errchk definition from script to job for wave prdgen and gempak adding definition of errchk which was undefined in these scripts Issue #1 and issue NOAA-EMC#233 - update GLDAS tag to gldas_gfsv16_release.v1.13.0 Issue #1 and issue NOAA-EMC#241 - update EMC_verif-global tag Issue #1 and issue NOAA-EMC#238 - remove ak_10m grid from config.wave and update checkout.sh tags for ufs-weather-model and EMC_gfs_wafs Issue #1 and issue NOAA-EMC#226 - update UPP tag to upp_gfsv16_release.v1.1.3 in Externals.cfg Issue #1 and issue NOAA-EMC#226 - update UPP tag to upp_gfsv16_release.v1.1.3 Issue #1 and issue NOAA-EMC#226 - update exgfs_atmos_grib2_special_npoess.sh for dbn_alert issue NOAA-EMC#227 reducing output bufr files to 64 levels per NCO request issue NOAA-EMC#227 reducing output bufr files to 64 levels per NCO request Issue #1: update ecflow to be consistent with NCO's gfs.v16.0.4 and update checkout to bring in new UPP tag (see issue NOAA-EMC#226) Upaded ush script scale_dec.sh Updated scripts gfs_v16.0 Conflicts: Externals.cfg sorc/checkout.sh Refs: NOAA-EMC#164
- add WGRIB2 setenv to module_base.hera; wgrib2 was unknown in post jobs without - set RUN_CCPP default to YES; should be running with CCPP now, consider removing variable Refs: NOAA-EMC#164
- update OznMon, Radmon modulefiles - update module_base.wcoss_dell_p3 - remove WW3 execs from link_fv3gfs.sh; will come from new build script - update wcoss_dell_p3 section of machine-setup.sh for hpc-stack - update checkout.sh for hpc-stack supported components (some test versions) Refs: NOAA-EMC#164
- update OznMon and RadMon modulefiles - update module_base.orion - update Orion if-block in machine-setup.sh - remove duplicate module use for WCOSS-Dell in machine-setup.sh Refs: NOAA-EMC#164
- consolidate RETRO variable in config.getic - move configuration settings from getic/init scripts to configs - add dependency to setup_workflow_fcstonly.py - add getic and init to task list at top of config.resources Refs: NOAA-EMC#178
- Update getic job to detect warm start config info and pull warm start RESTART files off HPSS and place in ROTDIR; just for retro ICs, will add ops after implementation - Add check to JGLOBAL_WAVE_PREP for prior cycle rtofs ROTDIR symlink; normally cycled mode would have already created this during prior cycle so added check for use in free-forecast mode Refs: NOAA-EMC#178
* origin/develop: Correct if-block syntax in config.postsnd and config.wavepostbndpnt after testing setup scripts FHMAX_WAV_IBP variable check for wavepostbndpnt job Bufr sounding job update Add config.resources.nco.static ecflow forecast job resource updates from NCO v16.0.7 install Update EMC_verif-global tag to verif_global_v1.13.5 Add missing symlinks for WAFS source code folders Update EMC_gfs_wafs tag to gfs_wafs.v6.0.19 Remove KEEPDATA from config.base.nco.static Pull in config changes from NCO v16.0.7 install Pull in workflow changes from NCO v16.0.7 install Update EMC_verif-global tag to verif_global_v1.13.4 ecFlow resource adjustments from NCO for forecast and post jobs issue NOAA-EMC#257 shorten run time on Mars Dell1 file system Refs: NOAA-EMC#164
* upstream/develop: Correct if-block syntax in config.postsnd and config.wavepostbndpnt after testing setup scripts FHMAX_WAV_IBP variable check for wavepostbndpnt job Bufr sounding job update Add config.resources.nco.static ecflow forecast job resource updates from NCO v16.0.7 install Update EMC_verif-global tag to verif_global_v1.13.5 Add missing symlinks for WAFS source code folders Update EMC_gfs_wafs tag to gfs_wafs.v6.0.19 Remove KEEPDATA from config.base.nco.static Pull in config changes from NCO v16.0.7 install Pull in workflow changes from NCO v16.0.7 install remove flags that were not present in Makefiles update jasper to 2.x.25. remove compiler flag in fv3nc2nemsio Update EMC_verif-global tag to verif_global_v1.13.4 another use of _d where an _4 is needed Adjust how target is set for build_workflow_utils Add workflow_utils to build_all and link scripts copy/paste error from enkf_chgres_recenter.fd to enkf_chgres_recenter_nc.fd. When going from nemsio to netcdf, the linking of ip, sp and w3nco changed from _d to _4. update .gitignore to exclude build and install directories as well as compiled files. bugfix in build_workflow_utils.sh hack. nceplibs-ncio now creates the module ncio and not fv3gfs_ncio. Update EMC_verif-global tag to verif_global_v1.13.4 add cmake build capability for workflow utilities ecFlow resource adjustments from NCO for forecast and post jobs issue NOAA-EMC#257 shorten run time on Mars Dell1 file system Refs: NOAA-EMC#178
GitHub repository for the UFS weather model only. This repo now contains UFS-Aerosols, the aerosol component based on NASA's GOCART. Since we are using a single repository for both S2S and coupled aerosols, the -a option was removed from checkout.sh and added to build_all.sh. This option is passed to build_ufs_coupled.sh and partial_build.sh, which have been streamlined and now accept both short and long options: build_ufs_coupled.sh: -a, --aerosols -c, --coupled partial_build.sh: -a, --aerosols -c, --coupled -h, --help -v, --verbose
…d FV3 namelist parser Refs: NOAA-EMC#230
- removed CROW FirstTrue check when building config.nsst from nsst.yaml - replace nst_spinup_logic with NST_SPINUP variable that is parsed from variable dictionary - nst_spinup_logic not needed currently Refs: NOAA-EMC#230
- set NST_MODEL=2 (turns it on) - add additional NSST namelist variables: NST_SPINUP, NST_RESV, ZSEA1, ZSEA2 - set NST_SPINUP=1 (NSST will spinup) - change CCPP_SUITE from FV3_GFS_v16_coupled to FV3_GFS_v16_couplednsst Refs: NOAA-EMC#230
Adds the eps_imesh setting to the nems.configure files when CICE is on. Refs: NOAA-EMC#324, NOAA-EMC#333
The modulefile in UFS doesn't load some modules needed for the forecast script at runtime, notably produtil, which provides err_chk. The module for the forecast job is changed back to module_base for the time being. Refs: NOAA-EMC#336
- remove default value for start (EXP_WARM_START) - if user provides start flag then use it for EXP_WARM_START - if user doesn't provide start flag then make a decision for them based on resolution - if start=None and res=768 then start=warm - if start=None and res!=768 then start=cold Refs: NOAA-EMC#353
Correct wrong settings for high-res warm-start free-forecast
WalterKolczynski-NOAA
added
maintenance
Contributor
Author
| fi | ||
| export COMIN_WAV_RTOFS=${COMIN_WAV_RTOFS:-$ROTDIR} | ||
| fi | ||
| fi |
Contributor
There was a problem hiding this comment.
Please see /scratch2/NCEPDEV/climate/Jessica.Meixner/p7update/mergedev/jobs/JGLOBAL_WAVE_PREP and update this file.
The new section with BRPDY should also be behind the if [ $WW3CURINP = "YES" ] statement and the "COMIN_WAV_ICE" line is repeated. The COMIN_WAV_RTOFS also needs to be in the if statement block.
WalterKolczynski-NOAA
added
ON HOLD
and removed
blocked
Contributor
|
@WalterKolczynski-NOAA I saw that this was "on hold" and based on your comment it was waiting on another PR to be merged, which has now been merged. There's still the comment that I made before that needs to be addressed, but I wanted to see if I needed to continue my review of this PR or if this was still on hold? |
Contributor
Author
|
With the move away from coupled-crow, I'm closing this PR but I'll keep the branch for a while just in case. |
zhanglikate
pushed a commit
to zhanglikate/global-workflow
that referenced
this pull request
Oct 6, 2022
* update fv3 and use new post lib * update fv3 to add Lambert conformal * add inline post in regional_quilt test, add inline post timer and fv3lam itag * update composite reflectivity name, fix field name name refl_10cm, fix cwm for post_regional, fix wtmpsfc in post, fix syntax in post_regional.F90, fix openmp sst field in regional post * add inline post for hafs regional latlon grid, use one input file directory for regional tests * add fv3_ccpp_regional_quilt_hafs test * update lam/hafs post control file with 75mb removed * fix fcstgrid and hbot, use hpc-stapc upp lib on hera * update upp lib to 10.0.4 * add lam3km xml file * fix the suite name in suite_FV3_GFS_v15_thompson_mynn_lam3km.xml * update post_itag_fv3lam * Add timing info for each test; skip-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the coupled-crow branch with current develop.