Move all default values of configurable variables into defaults/#30
Merged
Conversation
added 3 commits
March 4, 2020 22:04
move default value into defaults/
It's better if we have one place to manage default values for configurable variables other than two Default values only for reference. Please throughly test to make sure it could reproduce.
Contributor
Author
|
@JessicaMeixner-NOAA @binli2337 This is an overdue change that put default values into defaults/. As of now, some of them are in defaults/ while some of them are in schema/, which is hard to manage. Please make sure it could reproduce the EXPDIR as of now. You may not need to run the entire experiment, just reproduce the EXPDIR would be OK. |
Contributor
|
@JianKuang-NOAA I'll test and let you know the results. |
binli2337
approved these changes
Mar 9, 2020
default field table change to match current selection
Contributor
|
@binli2337 can you share your control directory location so I can use it to test my next round of changes against it? |
zhanglikate
pushed a commit
to zhanglikate/global-workflow
that referenced
this pull request
Oct 6, 2022
…_dev_emc_20200625 Update gsd/develop from dev/emc 2020/06/25 and mods to MYNN sfc and PBL for fractional/coupled
TerrenceMcGuinness-NOAA
added a commit
that referenced
this pull request
Jun 8, 2023
added user env needs in hera action
aerorahul
pushed a commit
that referenced
this pull request
Jul 1, 2024
…2700) This PR updates the `gdas.cd` hash to bring in new JCB conventions. Resolves #2699 From #2654 This PR will move much of the staging code that take place in the python initialization subroutines of the variational and ensemble DA jobs into Jinja2-templated YAML files to be passed into the wxflow file handler. Much of the staging has already been done this way, but this PR simply expands that strategy. The old Python routines that were doing this staging are now removed. This is part of a broader refactoring of the pygfs tasking. wxflow PR [#30](NOAA-EMC/wxflow#30) is a companion to this PR. Co-authored-by: danholdaway <danholdaway@users.noreply.github.com> Co-authored-by: DavidNew-NOAA <david.new@noaa.gov> Co-authored-by: DavidNew-NOAA <134300700+DavidNew-NOAA@users.noreply.github.com> Co-authored-by: Dan Holdaway <27729500+danholdaway@users.noreply.github.com>
bbakernoaa
pushed a commit
to bbakernoaa/global-workflow
that referenced
this pull request
Mar 19, 2026
… EARTH_GRID_COMP to UFSDriver (NOAA-EMC#1239) * Require specific package version in top-level CMakeLists.txt * Rename EARTH_GRID_COMP to UFSDriver * Update s4 support (NOAA-EMC#31) * Updated S4 compiler versions NOAA-EMC#1223 * Single dt output (NOAA-EMC#30)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is of a clean up. All default values are moved to defaults/ as it should be.
Historically, a lot of default values are in /schema. This make it an extra burden for developers to check if where are the default values set, if any, and where. This is not right.
In this way, developers only need to go to /defaults to check if the default values are there and with a desired value.
The usage of CROW won't change otherwise.