Skip to content

Update global atmos vminmon job with COMIN/COMOUT for COM prefix#2939

Merged
WalterKolczynski-NOAA merged 7 commits into
NOAA-EMC:developfrom
mingshichen-noaa:feature/atmos_vminmon_com_in_out
Sep 21, 2024
Merged

Update global atmos vminmon job with COMIN/COMOUT for COM prefix#2939
WalterKolczynski-NOAA merged 7 commits into
NOAA-EMC:developfrom
mingshichen-noaa:feature/atmos_vminmon_com_in_out

Conversation

@mingshichen-noaa
Copy link
Copy Markdown
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global minimization monitor job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Comment thread jobs/JGLOBAL_ATMOS_VMINMON Outdated
@mingshichen-noaa mingshichen-noaa force-pushed the feature/atmos_vminmon_com_in_out branch from c375c15 to b0956d0 Compare September 20, 2024 14:14
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mingshichen-noaa !

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. label Sep 20, 2024
@emcbot emcbot added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels Sep 20, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 20, 2024

CI Update on Wcoss2 at 09/20/24 03:50:11 PM
============================================
Cloning and Building global-workflow PR: 2939
with PID: 181934 on host: clogin03

@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels Sep 20, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 20, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Sep 20 15:55:34 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 09/20/24 04:37:00 PM
Case setup: Completed for experiment C48_ATM_b0956d0f
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_b0956d0f
Case setup: Skipped for experiment C48_S2SWA_gefs_b0956d0f
Case setup: Completed for experiment C48_S2SW_b0956d0f
Case setup: Completed for experiment C96_atm3DVar_extended_b0956d0f
Case setup: Skipped for experiment C96_atm3DVar_b0956d0f
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_b0956d0f
Case setup: Completed for experiment C96C48_hybatmDA_b0956d0f
Case setup: Completed for experiment C96C48_ufs_hybatmDA_b0956d0f

@emcbot emcbot added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Sep 21, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Sep 21, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_b0956d0f *** SUCCESS *** at 09/20/24 06:00:29 PM
Experiment C48_S2SW_b0956d0f *** SUCCESS *** at 09/20/24 06:21:24 PM
Experiment C96C48_hybatmDA_b0956d0f *** SUCCESS *** at 09/20/24 06:56:32 PM
Experiment C96C48_hybatmaerosnowDA_b0956d0f *** SUCCESS *** at 09/20/24 07:42:30 PM
Experiment C96C48_ufs_hybatmDA_b0956d0f *** SUCCESS *** at 09/20/24 08:42:29 PM
Experiment C96_atm3DVar_extended_b0956d0f *** SUCCESS *** at 09/21/24 03:56:34 AM

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 7bdb362 into NOAA-EMC:develop Sep 21, 2024
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
… // Fix fpe in MOM6 NOAA-EMC#2927 (NOAA-EMC#2932)

* UFSWM - Update inline post, add route handle opt, fix MOM6 divide by zero
  * UFSATM - Update inline post read interface and upp hash.
     * upp - Change BRTMP into BRTEMP for GFS, GEFS, SFS
  * MOM6 - Fix divide by zero fpe in MOM_oda_incupd.F90

---------

Co-authored-by: Dusan Jovic <dusan.jovic@noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants