Cleanup job for GEFS#2919
Merged
Merged
Conversation
AntonMFernando-NOAA
requested review from
DavidHuber-NOAA,
WalterKolczynski-NOAA and
aerorahul
aerorahul
reviewed
Sep 13, 2024
Contributor
aerorahul
left a comment
aerorahul
left a comment
There was a problem hiding this comment.
looks good.
just a couple of comments.
AntonMFernando-NOAA
force-pushed
the
cleanup/gefs
branch
from
95ba0e8 to
16df2ee
Compare
WalterKolczynski-NOAA
requested changes
Sep 13, 2024
Contributor
WalterKolczynski-NOAA
left a comment
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
We will run this through the normal CI tests when it is complete, but to test it you'll need to run several cycles to test the cleanup bit properly. We don't keep a bunch of GEFS initial conditions around, so work with the ensemble team to set that up.
WalterKolczynski-NOAA
approved these changes
Sep 14, 2024
Contributor
WalterKolczynski-NOAA
left a comment
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
Conditionally approved pending CI and manual completion of a longer GEFS test.
aerorahul
approved these changes
Sep 14, 2024
aerorahul
approved these changes
Sep 14, 2024
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Sep 16, 2024
* origin/develop: Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917) Cleanup job for GEFS (NOAA-EMC#2919) Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912) add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922) Support gefs C48 on Azure (NOAA-EMC#2881) Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Sep 16, 2024
* emc/develop: Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917) Cleanup job for GEFS (NOAA-EMC#2919) Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912) add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922) Support gefs C48 on Azure (NOAA-EMC#2881) Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914) Add new UPP links to .gitignore (NOAA-EMC#2904)
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
Sep 17, 2024
…al_obs_path * origin/develop: Update global atmos upp job to use COMIN/COMOUT (NOAA-EMC#2867) Update config.resources for bufr sounding job postsnd (NOAA-EMC#2917) Cleanup job for GEFS (NOAA-EMC#2919) Build GDASApp and unset memory in Gaea-C5 xml files (NOAA-EMC#2912) add 1 deg ocean/ice info to parm/config/gfs/config.resources (NOAA-EMC#2922) Support gefs C48 on Azure (NOAA-EMC#2881) Disable native grid writes for non-JEDI experiments; update C384 compression options (NOAA-EMC#2914)
bbakernoaa
pushed a commit
to bbakernoaa/global-workflow
that referenced
this pull request
Sep 19, 2024
As forecast ensemble jobs are added to the global workflow, this PR ensures the output is being cleaned up properly once it is no longer needed. Resolves NOAA-EMC#833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As forecast ensemble jobs are added to the global workflow, this PR ensures the output is being cleaned up properly once it is no longer needed.
Resolves #833
Type of change
Change characteristics
How has this been tested?
Checklist