Skip to content

Add fix for metplus jobs when gfs_cyc=2 or 4 #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidHuber-NOAA merged 11 commits into from
Aug 1, 2024
Merged

Add fix for metplus jobs when gfs_cyc=2 or 4 #2791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
935e8de
Add fix for metplus jobs when gfs_cyc=2 or 4
DavidHuber-NOAA Jul 25, 2024
b52bf6d
Make fixes to sequences and increments
DavidHuber-NOAA Jul 25, 2024
fa9507b
Run the metp jobs non-exclusively
DavidHuber-NOAA Jul 26, 2024
e12a4a6
Add EDATE_GFS for metp tasks
DavidHuber-NOAA Jul 26, 2024
859de17
Update verif-global to fix cycle selection
DavidHuber-NOAA Jul 26, 2024
2379a6c
Update verif-global to derive fhr_intvl
DavidHuber-NOAA Jul 29, 2024
703a084
Merge remote-tracking branch 'origin/develop' into fix/metp_gfs_cyc
DavidHuber-NOAA Jul 29, 2024
aff8f45
Point verif-global back to auth repo
DavidHuber-NOAA Jul 29, 2024
78ac751
Reenable METplus jobs
DavidHuber-NOAA Jul 29, 2024
66fbafe
Merge remote-tracking branch 'origin/develop' into fix/metp_gfs_cyc
DavidHuber-NOAA Jul 30, 2024
dc6e246
Merge branch 'fix/metp_gfs_cyc' of github.com:davidhuber-noaa/global-…
DavidHuber-NOAA Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions parm/config/gfs/config.base
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,8 +449,6 @@ export binary_diag=".false."

# Verification options
export DO_METP="@DO_METP@" # Run METPLUS jobs - set METPLUS settings in config.metp
# TODO Reenable METplus jobs when issue #2790 is resolved
export DO_METP="NO"
export DO_FIT2OBS="YES" # Run fit to observations package
export DO_VRFY_OCEANDA="@DO_VRFY_OCEANDA@" # Run SOCA Ocean and Seaice DA verification tasks

Expand Down
2 changes: 1 addition & 1 deletion parm/config/gfs/config.metp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ echo "BEGIN: config.metp"
# Get task specific resources
. "${EXPDIR}/config.resources" metp

export nproc=${npe_metp:-1}
export nproc=${tasks_per_node:-1}

export RUN_GRID2GRID_STEP1="YES" # Run grid-to-grid verification using METplus
export RUN_GRID2OBS_STEP1="YES" # Run grid-to-obs verification using METplus
Expand Down
2 changes: 1 addition & 1 deletion parm/config/gfs/config.resources
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ case ${step} in
walltime_gfs="06:00:00"
ntasks=4
tasks_per_node=4
export is_exclusive=True
export memory="80G"
;;

"echgres")
Expand Down
2 changes: 1 addition & 1 deletion sorc/verif-global.fd
Open in desktop
Submodule verif-global.fd updated 2 files
+38 −11 ush/run_verif_global_in_global_workflow.sh
+17 −3 ush/set_init_valid_fhr_info.py
3 changes: 2 additions & 1 deletion workflow/rocoto/gfs_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1799,7 +1799,8 @@ def metp(self):

metpenvars = self.envars.copy()
if self.app_config.mode in ['cycled']:
metpenvar_dict = {'SDATE_GFS': self._base.get('SDATE_GFS').strftime("%Y%m%d%H")}
metpenvar_dict = {'SDATE_GFS': self._base.get('SDATE_GFS').strftime("%Y%m%d%H"),
'EDATE_GFS': self._base.get('EDATE_GFS').strftime("%Y%m%d%H")}
elif self.app_config.mode in ['forecast-only']:
metpenvar_dict = {'SDATE_GFS': self._base.get('SDATE').strftime("%Y%m%d%H")}
metpenvar_dict['METPCASE'] = '#metpcase#'
Expand Down