Skip to content

Removes misleading "No such file or directory" syntax errors from output files #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WalterKolczynski-NOAA merged 11 commits into from
Jun 19, 2024
Merged

Removes misleading "No such file or directory" syntax errors from output files #2688

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ea20d5e
Removing eroneous missing file messages.
HenryRWinterbottom Jun 10, 2024
98b7ad2
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 10, 2024
e7f5d19
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 12, 2024
06456f3
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 13, 2024
7fc3aa5
Update scripts/exglobal_diag.sh
HenryRWinterbottom Jun 14, 2024
def8400
Merge branch 'develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 14, 2024
d164850
Merge branch 'develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 14, 2024
add90f1
Merge branch 'develop' into feature/gfsv17_issue_1252
HenryRWinterbottom Jun 17, 2024
849559d
Addressed reviewer comments.
HenryRWinterbottom Jun 17, 2024
bc1828f
Addressed reviewer comments.
HenryRWinterbottom Jun 17, 2024
5345eb1
Addressed reviewer comments.
HenryRWinterbottom Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions scripts/exglobal_diag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,12 @@ EOFdiag
rlist="conv_gps conv_ps conv_pw conv_q conv_sst conv_t conv_uv saphir"
for rtype in $rlist; do
set +e
${CHGRP_CMD} *${rtype}*
${STRICT_ON:-set -e}
for rfile in *"${rtype}"*; do
if [[ -s "${rfile}" ]]; then
${CHGRP_CMD} "${rfile}"
${STRICT_ON:-set -e}

@aerorahul aerorahul Jun 15, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be out of the for loop.
If there are no files that match the *"${rtype}" or if the if condition is not satisfied, set +e will prevail at the end of the for loop. set -e should be set there based on how it is in develop.

@WalterKolczynski-NOAA WalterKolczynski-NOAA Jun 17, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are checking for the file's existence, I'm not sure set +e is needed anymore at all.

@HenryRWinterbottom HenryRWinterbottom Jun 17, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm that my update makes the correction(s) that both of you are suggesting.

fi
done
Comment thread
HenryRWinterbottom marked this conversation as resolved.
done

# If requested, create diagnostic file tarballs
Expand Down