-
Notifications
You must be signed in to change notification settings - Fork 217
Update wave jobs to use COMIN/COMOUT #2643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
63c47ab
74370c4
47f873c
8427e46
257ec6b
5bafc6b
1861a77
b8e0c00
8432581
3118937
31082aa
a9a0258
94a9688
cdb0e82
883fa7c
2a81ae8
87e2492
4d27a6c
cb1764c
1241ede
b0c7bad
4b2f7ce
8f65499
cc4b281
d17d688
7438915
226e112
2acd4cc
52bfa61
31e3e88
6be0cef
4ce3fe5
96e3b42
a6b36c7
a3fcbe1
4a5fef0
0131597
526c64c
fc6d0c2
e125237
3351699
0c53d4b
5b35906
cde9194
1186cad
cf666ea
cfc4f78
b224d62
a549600
03eba4e
416b524
452fcd9
7401664
acbf9c9
0fed287
0f91c5c
7922af7
eb5fe34
9ecbfd5
0134119
abef5ef
401bbba
ccc0718
0474c12
aff4814
6214778
26ba301
11a7937
67417a3
63904c2
fbbd643
e17eec7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,13 @@ export errchk=${errchk:-err_chk} | |
| export MP_PULSE=0 | ||
|
|
||
| # Set COM Paths and GETGES environment | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_WAVE_PREP COM_WAVE_HISTORY COM_WAVE_STATION | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMIN_WAVE_PREP:COM_WAVE_PREP_TMPL \ | ||
| COMIN_WAVE_STATION:COM_WAVE_STATION_TMPL \ | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
| COMOUT_WAVE_HISTORY:COM_WAVE_HISTORY_TMPL \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what is being written out in
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic was derived from here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @aerorahul What is the verdict here?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where are the inputs derived from in this job?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HenryWinterbottom-NOAA I still do not think we need a COMOUT_WAVE_HISTORY. If that means that we remove it from line 18 as well, I think that's okay.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Jessica is correct. I did an audit of these last week,
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HenryWinterbottom-NOAA COMOUT_WAVE_HISTORY should be removed here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JessicaMeixner-NOAA Thank you. I missed this in the thread. Fixed. |
||
| COMOUT_WAVE_STATION:COM_WAVE_STATION_TMPL | ||
|
|
||
| if [[ ! -d ${COM_WAVE_STATION} ]]; then mkdir -p "${COM_WAVE_STATION}"; fi | ||
| if [[ ! -d ${COMIN_WAVE_STATION} ]]; then mkdir -p "${COMIN_WAVE_STATION}"; fi | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Set wave model ID tag to include member number | ||
| # if ensemble; waveMEMB var empty in deterministic | ||
|
|
@@ -36,7 +40,7 @@ if [ ${err} -ne 0 ]; then | |
| fi | ||
|
|
||
| ########################################## | ||
| # Remove the Temporary working directory | ||
| # Remove the Temporary working directory | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
| ########################################## | ||
| cd ${DATAROOT} | ||
| [[ ${KEEPDATA} = "NO" ]] && rm -rf ${DATA} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,9 +13,13 @@ export CDATE=${PDY}${cyc} | |
| export MP_PULSE=0 | ||
|
|
||
| # Set COM Paths and GETGES environment | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_WAVE_PREP COM_WAVE_HISTORY COM_WAVE_STATION | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMIN_WAVE_PREP:COM_WAVE_PREP_TMPL \ | ||
| COMIN_WAVE_STATION:COM_WAVE_STATION_TMPL \ | ||
| COMOUT_WAVE_HISTORY:COM_WAVE_HISTORY_TMPL \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this a
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just did a quick check and I don't see anywhere that we're writing out to the wave history directory - although it is a bit odd considering the line for creating the directory. I assume that's a mistake from copy/pasting from something else and was not properly cleaned up.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for the clarification, @JessicaMeixner-NOAA. In that case, all
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think COMOUT_WAVE_HISTORY -> COMIN_WAVE_HISTORY I'm checking on COMIN_WAVE_STATION I think this should be COMOUT... but i'll have to look .
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, WAVE_STATION is where output goes: https://github.com/NOAA-EMC/global-workflow/blob/develop/ush/wave_tar.sh#L185 So COMIN_WAVE_STATION -> COMOUT_WAVE_STATION WAVE_PREP and WAVE_HISTORY are where inputs are coming from.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @JessicaMeixner-NOAA
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @WalterKolczynski-NOAA Can you please confirm if the suggestions, above, are valid? These seem to conflict with https://github.com/HenryWinterbottom-NOAA/global-workflow/blob/feature/gwdev_issue_2451/ush/forecast_postdet.sh
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HenryWinterbottom-NOAA the forecast model writes to this location, this post job reads from this location. |
||
| COMOUT_WAVE_STATION:COM_WAVE_STATION_TMPL | ||
|
|
||
| if [[ ! -d ${COM_WAVE_STATION} ]]; then mkdir -p "${COM_WAVE_STATION}"; fi | ||
| if [[ ! -d ${COMIN_WAVE_STATION} ]]; then mkdir -p "${COMIN_WAVE_STATION}"; fi | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Set wave model ID tag to include member number | ||
| # if ensemble; waveMEMB var empty in deterministic | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,13 @@ export errchk=${errchk:-err_chk} | |
| export MP_PULSE=0 | ||
|
|
||
| # Set COM Paths and GETGES environment | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx COM_WAVE_PREP COM_WAVE_HISTORY COM_WAVE_STATION | ||
| YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \ | ||
| COMIN_WAVE_PREP:COM_WAVE_PREP_TMPL \ | ||
| COMIN_WAVE_STATION:COM_WAVE_STATION_TMPL \ | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
| COMOUT_WAVE_HISTORY:COM_WAVE_HISTORY_TMPL \ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again, no need for COMOUT_WAVE_HISTORY, unless I'm missing something.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @HenryWinterbottom-NOAA - I think this is still unresolved and should not be here.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was also resolved. |
||
| COMOUT_WAVE_STATION:COM_WAVE_STATION_TMPL | ||
|
|
||
| if [[ ! -d ${COM_WAVE_STATION} ]]; then mkdir -p "${COM_WAVE_STATION}"; fi | ||
| if [[ ! -d ${COMIN_WAVE_STATION} ]]; then mkdir -p "${COMIN_WAVE_STATION}"; fi | ||
|
HenryRWinterbottom marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Set wave model ID tag to include member number | ||
| # if ensemble; waveMEMB var empty in deterministic | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.