Skip to content

Update forecast job to use COMIN/COMOUT#2622

Merged
WalterKolczynski-NOAA merged 5 commits into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/comin_fcst
May 30, 2024
Merged

Update forecast job to use COMIN/COMOUT#2622
WalterKolczynski-NOAA merged 5 commits into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/comin_fcst

Conversation

@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented May 23, 2024

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the forecast job.

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • hybrid DA test on Hercules
  • GEFS test on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@WalterKolczynski-NOAA
Update forecast job to use COMIN/COMOUT
cf20258 
NCO has requested that each COM variable specify whether it is an
input or an output. This completes that process for the forecast
job.

Refs NOAA-EMC#2451
aerorahul
aerorahul approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@DavidHuber-NOAA DavidHuber-NOAA self-requested a review May 23, 2024 19:19
KateFriedman-NOAA
KateFriedman-NOAA approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @WalterKolczynski-NOAA !

DavidHuber-NOAA
DavidHuber-NOAA approved these changes May 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one suggestion regarding a comment.

Comment thread ush/forecast_postdet.sh Outdated
WalterKolczynski-NOAA and others added 3 commits May 24, 2024 11:00
@WalterKolczynski-NOAA @DavidHuber-NOAA
Correct error in comment
2e598ad 
Co-authored-by: David Huber <69919478+DavidHuber-NOAA@users.noreply.github.com>
@WalterKolczynski-NOAA
Merge branch 'develop' into feature/comin_fcst
80c6791
@WalterKolczynski-NOAA
Merge branch 'develop' into feature/comin_fcst
0bfda5e
@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 28, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 28, 2024 

CI Update on Wcoss2 at 05/28/24 09:38:38 PM
============================================
Cloning and Building global-workflow PR: 2622
with PID: 39572 on host: clogin01

@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels May 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 28, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Tue May 28 21:46:22 UTC 2024 on clogin01
---------------------------------------------------
Build: Completed at 05/28/24 09:58:19 PM
Case setup: Completed for experiment C48_ATM_0bfda5e3
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_0bfda5e3
Case setup: Skipped for experiment C48_S2SWA_gefs_0bfda5e3
Case setup: Completed for experiment C48_S2SW_0bfda5e3
Case setup: Completed for experiment C96_atm3DVar_extended_0bfda5e3
Case setup: Skipped for experiment C96_atm3DVar_0bfda5e3
Case setup: Skipped for experiment C96_atmaerosnowDA_0bfda5e3
Case setup: Completed for experiment C96C48_hybatmDA_0bfda5e3
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_0bfda5e3

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels May 28, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 28, 2024

Experiment C96_atmaerosnowDA FAILED on Hera with error logs:

/scratch1/NCEPDEV/global/CI/2622/RUNTESTS/COMROOT/C96_atmaerosnowDA_0bfda5e3/logs/2021122012/gdasfcst.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added the CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed label May 28, 2024
@emcbot emcbot removed the CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion label May 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 29, 2024

Experiment C96C48_hybatmDA_d2278c72 SUCCESS on Wcoss2 at 05/29/24 01:06:24 AM

@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels May 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 29, 2024

CI Passed Hercules at
Built and ran in directory /work2/noaa/stmp/CI/HERCULES/2622

@emcbot emcbot added CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels May 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 29, 2024

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2622

@emcbot
Copy link
Copy Markdown

emcbot commented May 29, 2024

Experiment C96_atm3DVar_extended_d2278c72 SUCCESS on Wcoss2 at 05/29/24 07:06:26 AM

@emcbot emcbot added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels May 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 29, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_d2278c72 *** SUCCESS *** at 05/29/24 12:12:16 AM
Experiment C48_S2SW_d2278c72 *** SUCCESS *** at 05/29/24 12:30:20 AM
Experiment C96C48_hybatmDA_d2278c72 *** SUCCESS *** at 05/29/24 01:06:24 AM
Experiment C96_atm3DVar_extended_d2278c72 *** SUCCESS *** at 05/29/24 07:06:26 AM

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 29, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 29, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels May 29, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels May 29, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 30, 2024

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2622

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit a54153f into NOAA-EMC:develop May 30, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/comin_fcst branch May 30, 2024 03:24
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Jun 4, 2024
@danholdaway
Merge remote-tracking branch 'upsteam/develop' into feature/rename_atm
97a63a7 
* upsteam/develop:
  Archiving cleanup (NOAA-EMC#2621)
  Switch to Rocky 9 built external packages on Hercules (NOAA-EMC#2608)
  Add the capability to use slurm reservation nodes (NOAA-EMC#2627)
  Update forecast job to use COMIN/COMOUT (NOAA-EMC#2622)
  Update to add 1-deg global wave grid (NOAA-EMC#2619)
  Add C384mx025_3DVarAOWCDA yamls (NOAA-EMC#2625)
  Script to keep Jenkins Agent persistent from cron (NOAA-EMC#2634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

+1 more reviewer

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@WalterKolczynski-NOAA @emcbot @aerorahul @KateFriedman-NOAA @DavidHuber-NOAA @TerrenceMcGuinness-NOAA