Update damping and time-step by yangfanglin · Pull Request #2575 · NOAA-EMC/global-workflow

yangfanglin · 2024-05-07T03:46:24Z

Description

Updates the model to use explicit Rayleigh damping for u/v and implicit damping to w. This improves model stability and allows for longer timesteps. Also unifies the GDAS and GFS to use the same damping.

Results from a test at the C1152 resolution (coupled model) can be found at https://www.emc.ncep.noaa.gov/gmb/wx24fy/C1152/newdamp/

Resolves #2574

Type of change

New feature (adds functionality)

Change characteristics

Is this a breaking change (a change in existing functionality)? NO
Does this change require a documentation update? NO

How has this been tested?

Checklist

Any dependent changes have been merged and published
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
New and existing tests pass with my changes
I have made corresponding changes to the documentation if necessary

modified: parm/config/gefs/config.fcst parm/config/gefs/config.ufs parm/config/gfs/config.fcst parm/config/gfs/config.ufs Apply new damping and time-step options to all supported atmos resolutions and to both GFS and GEFS. Apply the same damping to both GFS and GDAS cycles. Stronger damping was applied to GDAS in GFSv16. This new damping option includes both explicit Rayleigh damping aaplied to u and v and implicit damping applied to w.

yangfanglin · 2024-05-07T04:20:34Z

@lisa-bengtsson Lisa, would you like to add your following changes to branch https://github.com/yangfanglin/global-workflow/tree/dycore_update_hr4 and to this PR ?

xr_cnvcld = .false. for the C96 configuration only. It would need to be added both to config.ufs and to the parsing of the fv3 namelist. The default should be .true. for all other configurations.

WalterKolczynski-NOAA

Please review your code to make sure your indentation matches the surrounding code (using spaces) and remove the old code that has been commented out.

WalterKolczynski-NOAA

Looks fine other than one more indent fix.

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>

WalterKolczynski-NOAA

Conditionally approved pending successful completion of CI tests

lisa-bengtsson · 2024-05-07T14:20:21Z

Hi Fanglin, yes I can add the xr_cnvcld namelist, let me see if I can do it from Orion as Hera is down today.

CatherineThomas-NOAA · 2024-05-07T15:02:16Z

I can confirm that the parameters in the gfs configs match the parameters specified in the google doc. I will wait for @lisa-bengtsson's update before formally approving.

lisa-bengtsson · 2024-05-07T15:39:43Z

I added a PR: yangfanglin#1
I believe Fanglin needs to review and merge?

aerorahul

Looks good. Just a couple of comments that were possibly accidentally removed.

yangfanglin · 2024-05-07T15:56:38Z

I added a PR: yangfanglin#1 I believe Fanglin needs to review and merge?

reviewed. Need minor indentation adjustments

Add xr_cnvcld flag to namelist and configure files

lisa-bengtsson · 2024-05-07T17:01:13Z

Sorry Fanglin, those indentations have a life on their own, maybe you have better luck on your end?

yangfanglin · 2024-05-07T17:20:38Z

Sorry Fanglin, those indentations have a life on their own, maybe you have better luck on your end?

@WalterKolczynski-NOAA Walter, I had the same trouble too but you were able to "suggest" changes for which I accepted. Can you do the same to Lisa's modifications that I had already merged to this PR? The indentations are still not aligned.

emcbot · 2024-05-10T18:20:01Z

Experiment C48_S2SWA_gefs FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_S2SWA_gefs_d7732e04

emcbot · 2024-05-10T18:20:03Z

Experiment C48_S2SW FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_S2SW_d7732e04

emcbot · 2024-05-10T18:20:03Z

Experiment C48_ATM FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_ATM_d7732e04

emcbot · 2024-05-10T18:20:04Z

Experiment C96_atm3DVar FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C96_atm3DVar_d7732e04

emcbot · 2024-05-10T18:20:05Z

Experiment C96C48_hybatmDA FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C96C48_hybatmDA_d7732e04

emcbot · 2024-05-10T20:25:15Z

Experiment C96C48_hybatmDA FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C96C48_hybatmDA_d7732e04

emcbot · 2024-05-10T20:25:15Z

Experiment C96_atm3DVar FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/COMROOT/C96_atm3DVar_d7732e04/logs/2021122018/gdasfcst.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-05-10T20:25:23Z

Experiment C96_atm3DVar FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C96_atm3DVar_d7732e04

emcbot · 2024-05-10T20:47:48Z

Experiment C48_S2SWA_gefs FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_S2SWA_gefs_d7732e04

emcbot · 2024-05-10T20:47:49Z

Experiment C48_S2SW FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_S2SW_d7732e04

emcbot · 2024-05-10T20:47:51Z

Experiment C48_ATM FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_ATM_d7732e04

WalterKolczynski-NOAA · 2024-05-10T20:49:55Z

I'm trying to sort out what the issue is on Orion. Just ignore them for now.

emcbot · 2024-05-11T00:13:05Z

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2575

emcbot · 2024-05-11T00:24:26Z

Experiment C48_ATM FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/COMROOT/C48_ATM_d7732e04/logs/2021032312/gfsatmos_prod_f081-f087.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-05-11T00:24:32Z

Experiment C48_ATM FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_ATM_d7732e04

emcbot · 2024-05-11T21:23:20Z

Experiment C48_ATM FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/COMROOT/C48_ATM_d7732e04/logs/2021032312/gfsatmos_prod_f081-f087.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-05-11T21:23:26Z

Experiment C48_ATM FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_ATM_d7732e04

emcbot · 2024-05-12T03:38:17Z

Experiment C48_ATM FAILED on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/COMROOT/C48_ATM_d7732e04/logs/2021032312/gfsatmos_prod_f081-f087.log

Follow link here to view the contents of the above file(s): (link)

emcbot · 2024-05-12T03:38:24Z

Experiment C48_ATM FAILED on Orion in
/work2/noaa/stmp/CI/ORION/2575/RUNTESTS/C48_ATM_d7732e04

JessicaMeixner-NOAA · 2024-05-13T13:22:07Z

I just looked at this orion failure, it looks a bit odd. Do we think this is a machine issue or something else?

yangfanglin · 2024-05-13T13:30:47Z

One of the job failed at the post processing step for FH71 but the forecast started from FH78. It is strange. It appears the job was rerun as a warm start but this group of post job still tried to processing earlier forecast hours. Can someone remove everything and restart the CI test on Orion ?

emcbot · 2024-05-13T20:35:22Z

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2575

yangfanglin requested review from CatherineThomas-NOAA, JessicaMeixner-NOAA, KevinViner-NOAA, XiaqiongZhou-NOAA and aerorahul May 7, 2024 03:55

WalterKolczynski-NOAA requested changes May 7, 2024

View reviewed changes

remove old comments and clean up indentation mismatches

7028a73

WalterKolczynski-NOAA requested changes May 7, 2024

View reviewed changes

Comment thread parm/config/gefs/config.ufs

WalterKolczynski-NOAA changed the title ~~Update damping and time-step options to support GFSv17 and GEFSv13~~ Update damping and time-step May 7, 2024

yangfanglin and others added 2 commits May 7, 2024 08:56

Update parm/config/gefs/config.ufs

04161ab

Co-authored-by: Walter Kolczynski - NOAA <Walter.Kolczynski@noaa.gov>

Merge branch 'develop' into dycore_update_hr4

0afb3d3

WalterKolczynski-NOAA approved these changes May 7, 2024

View reviewed changes

Add xr_cnvcld flag to namelist and configure files

2d7f1c0

aerorahul approved these changes May 7, 2024

View reviewed changes

Comment thread parm/config/gefs/config.fcst

Comment thread parm/config/gfs/config.fcst

Lisa Bengtsson and others added 2 commits May 7, 2024 11:56

fix indendation

5aa5680

Merge pull request #1 from lisa-bengtsson/xr_cnvcld

9d73ba3

Add xr_cnvcld flag to namelist and configure files

add back removed comment line

43f4ef6

aerorahul reviewed May 7, 2024

View reviewed changes

Comment thread parm/config/gefs/config.ufs Outdated

aerorahul reviewed May 7, 2024

View reviewed changes

Comment thread parm/config/gfs/config.ufs Outdated

aerorahul reviewed May 7, 2024

View reviewed changes

Comment thread parm/config/gfs/config.ufs Outdated

Apply suggestions from code review

10f13b7

aerorahul reviewed May 7, 2024

View reviewed changes

Comment thread parm/config/gfs/config.ufs Outdated

emcbot removed the CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion label May 10, 2024

JessicaMeixner-NOAA approved these changes May 13, 2024

View reviewed changes

junwang-noaa mentioned this pull request May 30, 2024

Update damping and time step for global RT tests ufs-community/ufs-weather-model#2305

Closed

dpsarmie mentioned this pull request Jul 11, 2024

Update damping and time step parameters ufs-community/ufs-weather-model#2363

Merged

14 tasks

Conversation

yangfanglin commented May 7, 2024 • edited by WalterKolczynski-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Change characteristics

How has this been tested?

Checklist

Uh oh!

yangfanglin commented May 7, 2024

Uh oh!

WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

lisa-bengtsson commented May 7, 2024

Uh oh!

CatherineThomas-NOAA commented May 7, 2024

Uh oh!

lisa-bengtsson commented May 7, 2024

Uh oh!

aerorahul left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yangfanglin commented May 7, 2024

Uh oh!

lisa-bengtsson commented May 7, 2024

Uh oh!

yangfanglin commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

emcbot commented May 10, 2024

Uh oh!

WalterKolczynski-NOAA commented May 10, 2024

Uh oh!

emcbot commented May 11, 2024

Uh oh!

emcbot commented May 11, 2024

Uh oh!

emcbot commented May 11, 2024

Uh oh!

emcbot commented May 11, 2024

Uh oh!

emcbot commented May 11, 2024

Uh oh!

emcbot commented May 12, 2024

Uh oh!

emcbot commented May 12, 2024

yangfanglin commented May 7, 2024 •

edited by WalterKolczynski-NOAA

Loading

yangfanglin commented May 7, 2024 •

edited

Loading