Skip to content

Single Executable for main GDAS JEDI applications#2565

Merged
WalterKolczynski-NOAA merged 9 commits into
NOAA-EMC:developfrom
danholdaway:feature/build_jedi_exe
May 6, 2024
Merged

Single Executable for main GDAS JEDI applications#2565
WalterKolczynski-NOAA merged 9 commits into
NOAA-EMC:developfrom
danholdaway:feature/build_jedi_exe

Conversation

@danholdaway
Copy link
Copy Markdown
Contributor

@danholdaway danholdaway commented May 2, 2024

Description

Changes that accompany GDAS PR (NOAA-EMC/GDASApp/pull/1075) that allows building of a single gdas executable, which should be more compliant with NCO requirements.

Addresses NOAA-EMC/GDASApp#1085

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • GDAS ctests on Hera.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@danholdaway danholdaway mentioned this pull request May 2, 2024
Merged
@danholdaway danholdaway changed the title Feature/build jedi exe Single Executable for main GDAS JEDI applications May 2, 2024
aerorahul
aerorahul approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one minor comment.

Comment thread sorc/link_workflow.sh
WalterKolczynski-NOAA
WalterKolczynski-NOAA approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally approved pending successful completion of CI tests

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 2, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 2, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 2, 2024 

CI Update on Wcoss2 at 05/02/24 08:36:19 PM
============================================
Cloning and Building global-workflow PR: 2565
with PID: 29752 on host: clogin05

@emcbot emcbot added CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels May 2, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 2, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Thu May  2 20:43:03 UTC 2024 on clogin05
---------------------------------------------------
Build: Completed at 05/02/24 08:54:06 PM
Case setup: Completed for experiment C48_ATM_264f2fa2
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_264f2fa2
Case setup: Skipped for experiment C48_S2SWA_gefs_264f2fa2
Case setup: Completed for experiment C48_S2SW_264f2fa2
Case setup: Completed for experiment C96_atm3DVar_264f2fa2
Case setup: Skipped for experiment C96_atmaerosnowDA_264f2fa2
Case setup: Completed for experiment C96C48_hybatmDA_264f2fa2
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_264f2fa2

@emcbot emcbot added CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels May 2, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 2, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera with error logs:

/scratch1/NCEPDEV/global/CI/2565/RUNTESTS/COMROOT/C48mx500_3DVarAOWCDA_264f2fa2/logs/2021032418/gdasocnanalprep.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed and removed CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress labels May 2, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 2, 2024

Experiment C48mx500_3DVarAOWCDA FAILED on Hera in
/scratch1/NCEPDEV/global/CI/2565/RUNTESTS/C48mx500_3DVarAOWCDA_264f2fa2

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. and removed CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully labels May 6, 2024
@emcbot emcbot added CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 and removed CI-Wcoss2-Ready PR is ready for CI testing on WCOSS2. labels May 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024 

CI Update on Wcoss2 at 05/06/24 05:20:15 PM
============================================
Cloning and Building global-workflow PR: 2565
with PID: 11806 on host: clogin05

@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion CI-Wcoss2-Building CI testing is cloning/building on WCOSS2 labels May 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Mon May  6 17:27:09 UTC 2024 on clogin05
---------------------------------------------------
Build: Completed at 05/06/24 05:38:35 PM
Case setup: Completed for experiment C48_ATM_af5448f4
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_af5448f4
Case setup: Skipped for experiment C48_S2SWA_gefs_af5448f4
Case setup: Completed for experiment C48_S2SW_af5448f4
Case setup: Completed for experiment C96_atm3DVar_af5448f4
Case setup: Skipped for experiment C96_atmaerosnowDA_af5448f4
Case setup: Completed for experiment C96C48_hybatmDA_af5448f4
Case setup: Skipped for experiment C96C48_ufs_hybatmDA_af5448f4

@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

Experiment C48_ATM_af5448f4 SUCCESS on Wcoss2 at 05/06/24 06:51:16 PM

@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

Experiment C96_atm3DVar_af5448f4 SUCCESS on Wcoss2 at 05/06/24 07:57:20 PM

@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

Experiment C96C48_hybatmDA_af5448f4 SUCCESS on Wcoss2 at 05/06/24 07:57:29 PM

@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

Experiment C48_S2SW_af5448f4 SUCCESS on Wcoss2 at 05/06/24 08:06:08 PM

@emcbot emcbot added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels May 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

All CI Test Cases Passed on Wcoss2:

Experiment C48_ATM_af5448f4 *** SUCCESS *** at 05/06/24 06:51:16 PM
Experiment C96_atm3DVar_af5448f4 *** SUCCESS *** at 05/06/24 07:57:20 PM
Experiment C96C48_hybatmDA_af5448f4 *** SUCCESS *** at 05/06/24 07:57:29 PM
Experiment C48_S2SW_af5448f4 *** SUCCESS *** at 05/06/24 08:06:08 PM

@emcbot emcbot removed the CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress label May 6, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

CI Passed Orion at
Built and ran in directory /work2/noaa/stmp/CI/ORION/2565

@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request May 6, 2024
Merged
@emcbot
Copy link
Copy Markdown

emcbot commented May 6, 2024

CI Passed Hera at
Built and ran in directory /scratch1/NCEPDEV/global/CI/2565

@guoqing-noaa guoqing-noaa mentioned this pull request Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aerorahul aerorahul aerorahul approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

Assignees

No one assigned

Labels

CI-Hera-Passed **Bot use only** CI testing on Hera for this PR has completed successfully CI-Orion-Passed **Bot use only** CI testing on Orion for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@danholdaway @emcbot @aerorahul @WalterKolczynski-NOAA @RussTreadon-NOAA