Skip to content

Add mean/spread for atmos grib2#2482

Merged
WalterKolczynski-NOAA merged 5 commits into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/gefs_atmwav_avg
Apr 16, 2024
Merged

Add mean/spread for atmos grib2#2482
WalterKolczynski-NOAA merged 5 commits into
NOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/gefs_atmwav_avg

Conversation

@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor

Description

Adds the basic mean and spread grib2 products for the atmosphere.

The new mean/spread files are named according to the new convention, though pres_${grid_type} may be changed to pgrb_${grid_type}. Either way, the input filenames will need to be updated when that change is made. For now, the mismatch means the unlettered grib files result in pres_.

Resolves #2296
Refs #1522

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • GEFS test on Orion

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@WalterKolczynski-NOAA WalterKolczynski-NOAA force-pushed the feature/gefs_atmwav_avg branch 3 times, most recently from 5013b8f to 7c17782 Compare April 15, 2024 18:11
@aerorahul
Copy link
Copy Markdown
Contributor

@NeilBarton-NOAA @bingfu-NOAA Can you please review so we can proceed with this PR?

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Apr 15, 2024
@GwenChen-NOAA
Copy link
Copy Markdown
Contributor

@JunDu-NOAA is the POC for GEFS atmos ensemble products. He may review this PR too.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera labels Apr 15, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 15, 2024
@NeilBarton-NOAA
Copy link
Copy Markdown
Contributor

I'm not very familiar with this job and files. @EricSinsky-NOAA Do you have any comments?

@EricSinsky-NOAA
Copy link
Copy Markdown
Contributor

@NeilBarton-NOAA scripts related to ensstat have been added to global-workflow in this PR, which allows for the generation of ensemble mean and spread products. The ensstat program has been added to gfs-utils in PR #52. All the changes in this current global-workflow PR look good.

@emcbot emcbot added CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress and removed CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion labels Apr 15, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 15, 2024

Experiment C48_S2SWA_gefs failed on Orion with error logs: /work2/noaa/stmp/CI/ORION/2482/RUNTESTS/COMROOT/C48_S2SWA_gefs_7c17782b/logs/2021032312/atmos_ensstat_f000.log
/work2/noaa/stmp/CI/ORION/2482/RUNTESTS/COMROOT/C48_S2SWA_gefs_7c17782b/logs/2021032312/atmos_ensstat_f006.log

Follow link here to view the contents of the above file(s): (link)

@emcbot
Copy link
Copy Markdown

emcbot commented Apr 15, 2024

Experiment C48_S2SW failed on Orion with error logs:

/work2/noaa/stmp/CI/ORION/2482/RUNTESTS/COMROOT/C48_S2SWA_gefs_7c17782b/logs/2021032312/atmos_ensstat_f000.log
/work2/noaa/stmp/CI/ORION/2482/RUNTESTS/COMROOT/C48_S2SWA_gefs_7c17782b/logs/2021032312/atmos_ensstat_f006.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot added CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed and removed CI-Orion-Running **Bot use only** CI testing on Orion for this PR is in-progress labels Apr 15, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 15, 2024

CI FAILED Orion at 04 15 16:23:31
Built and ran in directory /work2/noaa/stmp/CI/ORION/2482

@WalterKolczynski-NOAA WalterKolczynski-NOAA added CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion and removed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed labels Apr 16, 2024
@emcbot emcbot added CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion and removed CI-Orion-Ready **CM use only** PR is ready for CI testing on Orion labels Apr 16, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 16, 2024

Build failed on Orion with error logs:/work2/noaa/stmp/CI/ORION/2482/gfs/sorc/logs/build_gdas.log

Follow link here to view the contents of the above file(s): (link)

@emcbot emcbot removed the CI-Orion-Building **Bot use only** CI testing is cloning/building on Orion label Apr 16, 2024
@emcbot
Copy link
Copy Markdown

emcbot commented Apr 16, 2024

CI FAILED Orion at 04 16 00:22:16
Built and ran in directory /work2/noaa/stmp/CI/ORION/2482

@emcbot emcbot added the CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed label Apr 16, 2024
@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor Author

Even from a fresh copy of develop, build_gdas is failing on Orion:

-- [GDASApp] (1.0.0)
-- Feature TESTS enabled
-- Found Python3: /work2/noaa/da/python/opt/core/miniconda3/4.6.14/envs/gdasapp/bin/python3.7 (found version "3.7.12") found components: Interpreter 
CMake Error at gdas/test/CMakeLists.txt:8 (file):
  file DOWNLOAD HASH mismatch

    for file: [/work2/noaa/global/wkolczyn/save/global-workflow/develop/sorc/gdas.cd/build/gdas/test/gdasapp-fix-bda76f.tgz]
      expected hash: [bda76f96666405f72abef56ad4d7d5b93ca153cd7d675853fbdb199096949f8a]
        actual hash: [e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855]
             status: [28;"Timeout was reached"]



ctest for JGLOBAL_PREP_OCEAN_OBS
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_PREP
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_BMAT
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_RUN
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_ECEN
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_CHKPT
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_POST
ctest for JGDAS_GLOBAL_OCEAN_ANALYSIS_VRFY
CMake Error at gdas/test/atm/CMakeLists.txt:7 (file):
  file failed to create symbolic link
  '/work2/noaa/global/wkolczyn/save/global-workflow/develop/sorc/gdas.cd/build/gdas/test/testdata/gdas.t06z.adpsfc.tm00.bufr_d':
  No such file or directory

@WalterKolczynski-NOAA WalterKolczynski-NOAA added blocked Issue is currently being blocked by another issue. Include blocking issue # in description and removed CI-Orion-Failed **Bot use only** CI testing on Orion for this PR has failed blocked Issue is currently being blocked by another issue. Include blocking issue # in description labels Apr 16, 2024
@WalterKolczynski-NOAA
Copy link
Copy Markdown
Contributor Author

Testing may be unavailable for days. This PR only adds functionality to GEFS and that has been tested. Moving forward with merge without CI testing.

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 9052ec4 into NOAA-EMC:develop Apr 16, 2024
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/gefs_atmwav_avg branch April 16, 2024 20:53
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 17, 2024
* upstream/develop:
  Add rocoto `sh` tag, script to check netcdf file and apply this to check ocean output (NOAA-EMC#2484)
  Revert file name changes in off-line post (NOAA-EMC#2499)
  Add mean/spread for atmos grib2 (NOAA-EMC#2482)
  Upadte and tested CI Bash for WCOSS2 (NOAA-EMC#2481)
bbakernoaa pushed a commit to bbakernoaa/global-workflow that referenced this pull request Mar 19, 2026
* UFSWM - Thompson-Eidhammer microphysics code formatting
  * FV3 - Thompson-Eidhammer microphysics code formatting
    * ccpp-physics - Thompson-Eidhammer microphysics code formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add GEFS mean/spread products for atmosphere

7 participants