Skip to content

Fx path for exglobal_prep_ocean_obs.py in JGLOBAL_PREP_OCEAN_OBS #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShastriPaturi wants to merge 9 commits into from
Closed

Fx path for exglobal_prep_ocean_obs.py in JGLOBAL_PREP_OCEAN_OBS #2356

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f1e2a8
fix path
ShastriPaturi Feb 28, 2024
697f6f4
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Feb 29, 2024
4560ae4
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Feb 29, 2024
cb8e225
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Mar 1, 2024
5249f23
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Mar 1, 2024
9f8d5a2
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Mar 4, 2024
b4cfb2e
Merge branch 'NOAA-EMC:develop' into bugfix/jjob_prepoceanobs
ShastriPaturi Mar 4, 2024
30b2294
insitu BUFR2IODA related
ShastriPaturi Mar 4, 2024
81015c5
path to bufr2ioda
ShastriPaturi Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jobs/JGLOBAL_PREP_OCEAN_OBS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@ YMD=${PDY} HH=${cyc} generate_com -rx COMOUT_OBS:COM_OBS_TMPL

# Add prep_marine_obs.py to PYTHONPATH
export PYTHONPATH=${HOMEgfs}/sorc/gdas.cd/ush:${PYTHONPATH}
# Add gen_bufr2ioda.py to PYTHONPATH
export PYTHONPATH=${HOMEgfs}/sorc/gdas.cd/ush/ioda/bufr2ioda:${PYTHONPATH}

###############################################################
# Run relevant script

EXSCRIPT=${GDASPREPOCNOBSPY:-${HOMEgfs}/ush/exglobal_prep_ocean_obs.py}
EXSCRIPT=${GDASPREPOCNOBSPY:-${HOMEgfs}/scripts/exglobal_prep_ocean_obs.py}

@aerorahul aerorahul Mar 1, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this script is available as it is being linked in ush. See here

${EXSCRIPT}
status=$?
[[ ${status} -ne 0 ]] && exit "${status}"
Expand Down
4 changes: 4 additions & 0 deletions parm/config/gfs/config.prepoceanobs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ export OBS_YAML=${OBS_LIST}
# ocean analysis needs own dmpdir until standard dmpdir has full ocean obs
export DMPDIR=@DMPDIR@

# For BUFR2IODA json and python scripts
export JSON_TMPL_DIR=${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda

@aerorahul aerorahul Mar 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export JSON_TMPL_DIR=${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda
export JSON_TMPL_DIR=${HOMEgfs}/parm/gdas/ioda/bufr2ioda

@AndrewEichmann-NOAA AndrewEichmann-NOAA Apr 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aerorahul Trying to address this before opening the new PR - is the idea to link the yaml files from ${HOMEgfs}/sorc/gdas.cd/parm/ioda/bufr2ioda to ${HOMEgfs}/parm/gdas/ioda/bufr2ioda?

@aerorahul aerorahul Apr 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
All files from sorc/gdas.cd should be linked in the appropriate location in HOMEgfs/. The scripts, yamls, etc. should reference them using EXECgfs or PARMgfs or SCRgfs or USHgfs instead of HOMEgfs/sorc/gdas.cd/+parm or scripts or ush.

export BUFR2IODA_PY_DIR=${HOMEgfs}/sorc/gdas.cd/ush/ioda/bufr2ioda
export KEEPDATA='YES'

@aerorahul aerorahul Mar 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is for debugging, then it should be removed from the PR.

# Get task specific resources
. "${EXPDIR}/config.resources" prepoceanobs
echo "END: config.prepoceanobs"