Skip to content

Adding debug option for all build scripts #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aerorahul merged 31 commits into from
Mar 1, 2024
Merged

Adding debug option for all build scripts #2326

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0e5184d
Adding debug option for all build scripts.
henrywinterbottom-wxdev Feb 17, 2024
ff4d6b9
Added BUILD_TYPE support.
HenryRWinterbottom Feb 17, 2024
553318f
Corrected BUILD_TYPE relative to what CMake expects.
HenryRWinterbottom Feb 17, 2024
83188dd
CMake is case-dependent.
HenryRWinterbottom Feb 19, 2024
029e02c
CMake is case-dependent.
HenryRWinterbottom Feb 19, 2024
d238b45
CMake is case-dependent.
HenryRWinterbottom Feb 19, 2024
5494798
Bringing branch UTD with WIP.
HenryRWinterbottom Feb 19, 2024
ab6b521
Update for CMake to pick up debug option.
HenryRWinterbottom Feb 20, 2024
36c304d
Removed left over debugging comments.
henrywinterbottom-wxdev Feb 21, 2024
72efbfa
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_300
HenryRWinterbottom Feb 22, 2024
20a8c16
Updates for gsi_monitor.fd.
HenryRWinterbottom Feb 23, 2024
026efbe
Merge branch 'feature/gfsv17_issue_300' of https://github.com/HenryWi…
HenryRWinterbottom Feb 23, 2024
8bc2b20
Update build_ww3prepost.sh
HenryRWinterbottom Feb 23, 2024
266a24f
Fixed conflict.
henrywinterbottom-wxdev Feb 23, 2024
b815bed
Case correction.
henrywinterbottom-wxdev Feb 23, 2024
193a4ba
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_300
HenryRWinterbottom Feb 26, 2024
69b8fa7
David Huber suggested updates.
henrywinterbottom-wxdev Feb 26, 2024
8d36d0c
Update sorc/build_ww3prepost.sh
HenryRWinterbottom Feb 26, 2024
490f675
Merge branch 'develop' into feature/gfsv17_issue_300
aerorahul Feb 27, 2024
2bdd520
Merge branch 'develop' into feature/gfsv17_issue_300
HenryRWinterbottom Feb 28, 2024
58d5470
Update requested by reviewer.
HenryRWinterbottom Feb 29, 2024
a6a4f6b
Committing prior to clean clone and build.
HenryRWinterbottom Feb 29, 2024
011d3bd
Merge branch 'feature/gfsv17_issue_300' of https://github.com/HenryWi…
HenryRWinterbottom Feb 29, 2024
fe44609
patch on HWs pr
aerorahul Feb 29, 2024
0abcd83
apply shellcheck fixes
aerorahul Mar 1, 2024
c051f0c
Merge branch 'NOAA-EMC:develop' into feature/gfsv17_issue_300
HenryRWinterbottom Mar 1, 2024
7b10512
Merge pull request #3 from aerorahul/patch/issue_300
HenryRWinterbottom Mar 1, 2024
bd84a8d
Update sorc/build_all.sh to eliminate upp special handling.
aerorahul Mar 1, 2024
7cba6d0
Merge branch 'develop' into feature/gfsv17_issue_300
aerorahul Mar 1, 2024
835ff69
Update sorc/build_gdas.sh to add trailing space.
aerorahul Mar 1, 2024
f6b1d6f
Update sorc/build_gdas.sh to force clean build directory with every i…
aerorahul Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sorc/build_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ function _usage() {
Builds all of the global-workflow components by calling the individual build
scripts in sequence.

Usage: ${BASH_SOURCE[0]} [-a UFS_app][-c build_config][-h][-j n][-v][-w]
Usage: ${BASH_SOURCE[0]} [-a UFS_app][-c build_config][-d][-h][-j n][-v][-w]
-a UFS_app:
Build a specific UFS app instead of the default
-d:
Build in debug mode
-g:
Build GSI
-h:
Expand All @@ -38,17 +40,22 @@ EOF
script_dir=$(cd "$(dirname "${BASH_SOURCE[0]}")" &> /dev/null && pwd)
cd "${script_dir}" || exit 1

BUILD_TYPE="Release" # This is the default for all applications.
Comment thread Fixed
_build_ufs_opt=""
_build_ufsda="NO"
_build_gsi="NO"
_build_debug=""
_verbose_opt=""
_wave_unst=""
_build_job_max=20
# Reset option counter in case this script is sourced
OPTIND=1
while getopts ":a:ghj:uvw" option; do
while getopts ":a:dghj:uvw" option; do
case "${option}" in
a) _build_ufs_opt+="-a ${OPTARG} ";;
d) _build_debug="-d"
export BUILD_TYPE="Debug"
Comment thread
aerorahul marked this conversation as resolved.
Outdated
;;
g) _build_gsi="YES" ;;
h) _usage;;
j) _build_job_max="${OPTARG} ";;
Expand Down Expand Up @@ -120,10 +127,10 @@ big_jobs=$((big_jobs+1))
build_opts["ufs"]="${_wave_unst} ${_verbose_opt} ${_build_ufs_opt}"

build_jobs["upp"]=6 # The UPP is hardcoded to use 6 cores
build_opts["upp"]=""
build_opts["upp"]="${_build_debug}"

build_jobs["ufs_utils"]=3
build_opts["ufs_utils"]="${_verbose_opt}"
build_opts["ufs_utils"]="${_verbose_opt}"

build_jobs["gfs_utils"]=1
build_opts["gfs_utils"]="${_verbose_opt}"
Expand Down Expand Up @@ -160,6 +167,7 @@ fi
requested_cpus=0
build_list=""
for build in "${!build_jobs[@]}"; do
BUILD_TYPE=${BUILD_TYPE:-"Release"}
Comment thread
aerorahul marked this conversation as resolved.
Outdated
if [[ -z "${build_list}" ]]; then
build_list="${build}"
else
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_gfs_utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ cwd=$(pwd)
OPTIND=1
while getopts ":j:dvh" option; do
case "${option}" in
d) export BUILD_TYPE="DEBUG";;
d) export BUILD_TYPE="Debug";;
v) export BUILD_VERBOSE="YES";;
j) export BUILD_JOBS="${OPTARG}";;
h)
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_gsi_enkf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -eux
OPTIND=1
while getopts ":j:dv" option; do
case "${option}" in
d) export BUILD_TYPE="DEBUG";;
d) export BUILD_TYPE="Debug";;
j) export BUILD_JOBS="${OPTARG}";;
v) export BUILD_VERBOSE="YES";;
:)
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_gsi_monitor.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cwd=$(pwd)
OPTIND=1
while getopts ":j:dv" option; do
case "${option}" in
d) export BUILD_TYPE="DEBUG";;
d) export BUILD_TYPE="Debug";;
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
Outdated
j) export BUILD_JOBS="${OPTARG}";;
v) export BUILD_VERBOSE="YES";;
:)
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_gsi_utils.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ cwd=$(pwd)
OPTIND=1
while getopts ":j:dv" option; do
case "${option}" in
d) export BUILD_TYPE="DEBUG";;
d) export BUILD_TYPE="Debug";;
j) export BUILD_JOBS="${OPTARG}";;
v) export BUILD_VERBOSE="YES";;
:)
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_ufs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ source "./tests/module-setup.sh"

MAKE_OPT="-DAPP=${APP} -D32BIT=ON -DCCPP_SUITES=${CCPP_SUITES}"
[[ ${PDLIB:-"OFF"} = "ON" ]] && MAKE_OPT+=" -DPDLIB=ON"
[[ ${BUILD_TYPE:-"Release"} = "DEBUG" ]] && MAKE_OPT+=" -DDEBUG=ON"
[[ ${BUILD_TYPE:-"Release"} = "Debug" ]] && MAKE_OPT+=" -DDEBUG=ON"
COMPILE_NR=0
CLEAN_BEFORE=YES
CLEAN_AFTER=NO
Expand Down
2 changes: 1 addition & 1 deletion sorc/build_ww3prepost.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ PDLIB="OFF"
while getopts ":j:a:dvw" option; do
case "${option}" in
a) APP="${OPTARG}";;
d) BUILD_TYPE="DEBUG";;
d) BUILD_TYPE="Debug";;
Comment thread
DavidHuber-NOAA marked this conversation as resolved.
j) BUILD_JOBS="${OPTARG}";;
v) export BUILD_VERBOSE="YES";;
w) PDLIB="ON";;
Expand Down