Allow user to provide ocean resolution at setup_expt invocation#2204
Closed
aerorahul wants to merge 12 commits into
Closed
Allow user to provide ocean resolution at setup_expt invocation#2204aerorahul wants to merge 12 commits into
aerorahul wants to merge 12 commits into
Conversation
KateFriedman-NOAA
approved these changes
Jan 10, 2024
Contributor
KateFriedman-NOAA
left a comment
KateFriedman-NOAA
left a comment
There was a problem hiding this comment.
Looks good! Left a few comments but approve pending any CI testing.
| raise NotImplementedError(f"Supported resolutions on {machine} are:\n{', '.join(supp_res)}") | ||
|
|
||
|
|
||
| def get_ocean_resolution(resdetatmos): |
Contributor
There was a problem hiding this comment.
Suggested change
| def get_ocean_resolution(resdetatmos): | |
| def get_default_ocean_resolution(resdetatmos): |
aerorahul
commented
Jan 10, 2024
7 tasks
KateFriedman-NOAA
added a commit
to KateFriedman-NOAA/global-workflow
that referenced
this pull request
Jan 11, 2024
Merge remote-tracking branch 'upstream/feature/setup_expt_oceanres' into feature/clean_out_rotdir * upstream/feature/setup_expt_oceanres: Update docs/doxygen/mainpage.h update default resdetocean update documentation instances of resdet and resens; add resdetocean update yamls for ci tests fix pynorm error add option to provide an ocean resolution during setup_expt.py
aerorahul
commented
Jan 11, 2024
Contributor
Author
|
Absorbed in #2204. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR:
setup_expt.py.--resdetoption to--resdetatmos--resdetocean. If a value<= 0.is provided, the program will choose based on pre-selected options.Type of change
Change characteristics
setup_expt.pyHow has this been tested?
create_experiment.pyand the variousci/casesyaml files and inspectedconfig.basein the respective experiment directories.Checklist