Skip to content

Use new GSI tag to turn on data#2102

Merged
aerorahul merged 3 commits into
NOAA-EMC:release/gfs.v16.3.12from
ADCollard:release/gfs.v16.3.12
Nov 30, 2023
Merged

Use new GSI tag to turn on data#2102
aerorahul merged 3 commits into
NOAA-EMC:release/gfs.v16.3.12from
ADCollard:release/gfs.v16.3.12

Conversation

@ADCollard
Copy link
Copy Markdown
Contributor

@ADCollard ADCollard commented Nov 29, 2023

This PR turns on active assimilation of NOAA-21 CrIS, NOAA-21 ATMS, GOES-18 Clear Sky Radiances and Metop-C ASCAT.

All substantive changes are confined to the fix directory of GSI and this PR simply checks out the gfsda.v16.3.12 tag of the GSI.

Resolves #2096

How has this been tested?

Clone and build on WCOSS2. Single cycle test.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@ADCollard
Copy link
Copy Markdown
Contributor Author

@KateFriedman-NOAA Does the GFS version number get incremented in versions/run.ver? It seems to have been in the past but I am not sure this is correct.

@ADCollard ADCollard added the production update Processing update in production label Nov 29, 2023
@ADCollard ADCollard marked this pull request as ready for review November 30, 2023 16:13
Comment thread docs/Release_Notes.gfs.v16.3.12.md Outdated
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo.

Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and includes expected changes for this. Thanks @ADCollard !

Comment thread docs/Release_Notes.gfs.v16.3.12.md Outdated
@KateFriedman-NOAA
Copy link
Copy Markdown
Contributor

@ADCollard Just one comment, forgot to mention I left it when approving this PR. Please address and we can merge it. Thanks!

Remove erroneous instructions
@ADCollard
Copy link
Copy Markdown
Contributor Author

@ADCollard Just one comment, forgot to mention I left it when approving this PR. Please address and we can merge it. Thanks!

@KateFriedman-NOAA It should be good now

@aerorahul aerorahul merged commit 32e0a64 into NOAA-EMC:release/gfs.v16.3.12 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

production update Processing update in production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants